Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 400 but not 500 when request archive with wrong format #17691

Merged
merged 5 commits into from
Nov 17, 2021
Merged

Return 400 but not 500 when request archive with wrong format #17691

merged 5 commits into from
Nov 17, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 17, 2021

Fix #17689

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 17, 2021
@lunny lunny force-pushed the lunny/return_correct_status_code branch from 43f6944 to f083211 Compare November 17, 2021 15:19
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 17, 2021
@zeripath
Copy link
Contributor

make lgtm work

@techknowlogick techknowlogick merged commit 81a4fc7 into go-gitea:main Nov 17, 2021
@lunny lunny deleted the lunny/return_correct_status_code branch November 18, 2021 02:14
lunny added a commit to lunny/gitea that referenced this pull request Nov 18, 2021
@lunny
Return 400 but not 500 when request archive with wrong format (go-git…
1deac31 
…ea#17691)
@lunny lunny mentioned this pull request Nov 18, 2021
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Nov 18, 2021
wxiaoguang pushed a commit that referenced this pull request Nov 19, 2021
@lunny
Return 400 but not 500 when request archive with wrong format (#17691) (
a088566 
#17700)

* Return 400 but not 500 when request archive with wrong format (#17691)
* Remove bundle because it's not in this version
@wxiaoguang wxiaoguang added this to the 1.16.0 milestone Nov 22, 2021
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@lunny
Return 400 but not 500 when request archive with wrong format (go-git…
97eb36a 
…ea#17691)
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KN4CK3R KN4CK3R KN4CK3R left review comments

@jotoho jotoho jotoho approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug type/testing
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.

Internal Server Error when attempting to download archive via API
7 participants
@lunny @zeripath @KN4CK3R @wxiaoguang @jotoho @techknowlogick @GiteaBot