Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove golint as linter #17609

Merged
merged 3 commits into from
Nov 11, 2021
Merged

Remove golint as linter #17609

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fc0054
Remove `golint` as linter
Nov 10, 2021
6404f7e
Merge branch 'main' into remove-golint
techknowlogick Nov 10, 2021
5f20b81
Merge branch 'main' into remove-golint
lunny Nov 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove golint as linter 
- Partialy resolvess #17596
- In the newer versions of `golangci-lint`, golint is  deprecated and
replaced by the `revive` linter. Thus removing the `golint` linter is a
good idea, as we're already using the `revive` linter which covers all
the current `golint` cases.
  • Loading branch information
Gusted committed Nov 10, 2021
commit 1fc005474942fc5fe2c5587568d66c0f49528a0e
1 change: 0 additions & 1 deletion .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ linters:
- unused
- structcheck
- varcheck
- golint
- dupl
#- gocyclo # The cyclomatic complexety of a lot of functions is too high, we should refactor those another time.
- gofmt
Expand Down