Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove golint as linter #17609

Merged
merged 3 commits into from
Nov 11, 2021
Merged

Remove golint as linter #17609

merged 3 commits into from
Nov 11, 2021

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Nov 10, 2021

  • Partialy resolvess Tracking issue: Updating golangci-lint #17596
  • In the newer versions of golangci-lint, golint is deprecated and replaced by the revive linter. Thus removing the golint linter is a good idea, as we're already using the revive linter which covers all the current golint cases.

- Partialy resolvess go-gitea#17596
- In the newer versions of `golangci-lint`, golint is  deprecated and
replaced by the `revive` linter. Thus removing the `golint` linter is a
good idea, as we're already using the `revive` linter which covers all
the current `golint` cases.
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 10, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 10, 2021
@techknowlogick techknowlogick added this to the 1.16.0 milestone Nov 10, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@0e189ee). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #17609   +/-   ##
=======================================
  Coverage        ?   45.50%           
=======================================
  Files           ?      794           
  Lines           ?    88861           
  Branches        ?        0           
=======================================
  Hits            ?    40439           
  Misses          ?    41904           
  Partials        ?     6518           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e189ee...6404f7e. Read the comment docs.

@wxiaoguang
Copy link
Contributor

I think this PR can be done by

together.

@lunny
Copy link
Member

lunny commented Nov 11, 2021

make L-G-T-M work.

@lunny lunny merged commit a4dc0c5 into go-gitea:main Nov 11, 2021
@Gusted Gusted deleted the remove-golint branch November 11, 2021 17:10
zeripath pushed a commit that referenced this pull request Nov 16, 2021
Backport #17598 
Backport #17606 
Backport #17608 
Backport #17609

- Since https://gitea.com/gitea/test-env/pulls/10 the golangci-lint has been upgraded and is erroring about new warnings in the code, this PR fixes those warnings.
@zeripath zeripath added the backport/done All backports for this PR have been created label Dec 25, 2021
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
- Partialy resolvess go-gitea#17596
- In the newer versions of `golangci-lint`, golint is  deprecated and
replaced by the `revive` linter. Thus removing the `golint` linter is a
good idea, as we're already using the `revive` linter which covers all
the current `golint` cases.

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/code-linting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants