Skip to content

Conversation

@6543
Copy link
Member

@6543 6543 commented Dec 26, 2020

close #14108

follow up (not backportable): #14150

@6543 6543 added type/bug backport/v1.13 topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them labels Dec 26, 2020
@6543 6543 added this to the 1.14.0 milestone Dec 26, 2020
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 26, 2020
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a more programmatic way of detecting these limits would be better but this will suffice

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 26, 2020
@zeripath zeripath changed the title Migration: drop to long repo topics Migration: drop too long repo topics Dec 26, 2020
@6543 6543 force-pushed the drop-too-long-repo-topics-on-migration branch 2 times, most recently from 9c89682 to 0ce0866 Compare December 27, 2020 00:11
@6543 6543 force-pushed the drop-too-long-repo-topics-on-migration branch from 0ce0866 to ce25460 Compare December 27, 2020 00:13
@6543
Copy link
Member Author

6543 commented Dec 27, 2020

@techknowlogick changed to 50

@codecov-io
Copy link

Codecov Report

Merging #14152 (ce25460) into master (cf9d471) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14152   +/-   ##
=======================================
  Coverage   42.36%   42.36%           
=======================================
  Files         728      728           
  Lines       78015    78021    +6     
=======================================
+ Hits        33049    33056    +7     
+ Misses      39540    39539    -1     
  Partials     5426     5426           
Impacted Files Coverage Δ
modules/migrations/gitea_uploader.go 6.64% <0.00%> (-0.08%) ⬇️
services/pull/pull.go 42.85% <0.00%> (+0.50%) ⬆️
routers/repo/view.go 38.24% <0.00%> (+0.64%) ⬆️
models/unit.go 49.31% <0.00%> (+2.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf9d471...ce25460. Read the comment docs.

@6543
Copy link
Member Author

6543 commented Dec 27, 2020

Backport: #14155

@6543 6543 added the backport/done All backports for this PR have been created label Dec 27, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 27, 2020
@lunny lunny merged commit 212fa34 into go-gitea:master Dec 27, 2020
@6543 6543 deleted the drop-too-long-repo-topics-on-migration branch December 27, 2020 01:24
techknowlogick pushed a commit that referenced this pull request Dec 27, 2020
* Migration: drop to long repo topics

* Update modules/migrations/gitea_uploader.go
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DB topic.name uses varying(25) which makes mirrors of repos with long topics fail

6 participants