Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change topic name size from 25 to 50 #14150

Merged
merged 4 commits into from
Dec 26, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 26, 2020

Fix #14108

@zeripath
Copy link
Contributor

I think we should just make this 255

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 26, 2020
@lafriks
Copy link
Member

lafriks commented Dec 26, 2020

What is the max size for github?

@6543
Copy link
Member

6543 commented Dec 26, 2020

@lunny created backportable fix: #14152

this pull should still go in too :)

@zeripath
Copy link
Contributor

zeripath commented Dec 26, 2020

What is the max size for github?

I'm not sure that there is one. I got it up to 100 characters without a problem. Let me take a look at pathological.

Error saving your changes: Repository topics Topics must start with a lowercase letter or number, consist of 35 characters or less, and can include hyphens.

So 35.

Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I suspect that we could easily get away with 255 here - 50 appears to be enough to cope with Github

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 26, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 26, 2020
@zeripath zeripath merged commit cf9d471 into go-gitea:master Dec 26, 2020
@lunny lunny deleted the lunny/fix_topic_size branch December 27, 2020 01:24
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DB topic.name uses varying(25) which makes mirrors of repos with long topics fail
6 participants