Fixed git args duplication #13411
Merged
Fixed git args duplication #13411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because newGit() invoked twice (inside PreInstallInit() and GlobalInit()) and git parameters is global object, all git commands call with duplicated args `-c credential.helper= -c protocol.version=2`
zeripath
approved these changes
Nov 3, 2020
Contributor
zeripath
left a comment
zeripath
left a comment
There was a problem hiding this comment.
damn Sorry I missed this.
GiteaBot
added
the
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## master #13411 +/- ##
==========================================
+ Coverage 42.12% 42.13% +0.01%
==========================================
Files 691 691
Lines 76002 76003 +1
==========================================
+ Hits 32017 32027 +10
+ Misses 38738 38728 -10
- Partials 5247 5248 +1
Continue to review full report at Codecov.
|
lafriks
approved these changes
Nov 3, 2020
GiteaBot
added
lgtm/done
Member
|
Shouldn't we remove the second call |
Contributor
|
It's part of setting.NewContext() |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because newGit() invoked twice (inside PreInstallInit() and GlobalInit()) and git parameters is global object, all git commands call with duplicated args
-c credential.helper= -c protocol.version=2