Fixed git args duplication (#13411)

POPSuL · web-flow · commit 7d16e6db8e1b · 2020-11-03T13:35:09.000+02:00
Because newGit() invoked twice (inside PreInstallInit() and
GlobalInit()) and git parameters is global object, all
git commands call with duplicated args
`-c credential.helper= -c protocol.version=2`
diff --git a/modules/setting/git.go b/modules/setting/git.go
@@ -74,6 +74,9 @@ func newGit() {
 		log.Fatal("Error retrieving git version: %v", err)
 	}
 
+	// force cleanup args
+	git.GlobalCommandArgs = []string{}
+
 	if git.CheckGitVersionAtLeast("2.9") == nil {
 		// Explicitly disable credential helper, otherwise Git credentials might leak
 		git.GlobalCommandArgs = append(git.GlobalCommandArgs, "-c", "credential.helper=")

Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,9 @@ func newGit() {`
`74`	`74`	`log.Fatal("Error retrieving git version: %v", err)`
`75`	`75`	`}`
`76`	`76`
	`77`	`+ // force cleanup args`
	`78`	`+ git.GlobalCommandArgs = []string{}`
	`79`	`+`
`77`	`80`	`if git.CheckGitVersionAtLeast("2.9") == nil {`
`78`	`81`	`// Explicitly disable credential helper, otherwise Git credentials might leak`
`79`	`82`	`git.GlobalCommandArgs = append(git.GlobalCommandArgs, "-c", "credential.helper=")`