Issue comment reactions should also check pull type #13349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A failure during migrating reactions should not cause failure of migration. Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
…-is-just-not-important
zeripath
added a commit
to techknowlogick/gitea
that referenced
this pull request
Oct 29, 2020
Unfortunately my final push to go-gitea#13344 didn't register - or I failed to push it properly. GetIssueCommentReactions in routers/api/v1/repo/issue_reaction.go also makes the same mistake.
Contributor
Author
GiteaBot
added
the
lgtm/need 2
Codecov Report
@@ Coverage Diff @@
## master #13349 +/- ##
==========================================
- Coverage 42.12% 42.11% -0.01%
==========================================
Files 689 689
Lines 75851 75853 +2
==========================================
Hits 31949 31949
Misses 38670 38670
- Partials 5232 5234 +2
Continue to review full report at Codecov.
|
adelowo
approved these changes
Oct 29, 2020
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Oct 29, 2020
GiteaBot
added
lgtm/done
techknowlogick
added a commit
that referenced
this pull request
Oct 29, 2020
* Migration failure during reaction migration from gitea (#13344) * Migrating reactions is just not that important A failure during migrating reactions should not cause failure of migration. Signed-off-by: Andrew Thornton <art27@cantab.net> * When checking issue reactions check the correct permission Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io> * Delete gitea_downloader.go * Backport #13349 Unfortunately my final push to #13344 didn't register - or I failed to push it properly. GetIssueCommentReactions in routers/api/v1/repo/issue_reaction.go also makes the same mistake. Co-authored-by: zeripath <art27@cantab.net>
6 tasks
6543
added
modifies/api
Member
|
skip changelog because it is included in unreleased 1.13.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately my final push to #13344 didn't register - or I failed to push it properly.
GetIssueCommentReactionsinrouters/api/v1/repo/issue_reaction.goalso makes the same mistake.This PR fixes this.