Migration failure during reaction migration from gitea (#13344) #13346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Migrating reactions is just not that important A failure during migrating reactions should not cause failure of migration. Signed-off-by: Andrew Thornton <art27@cantab.net> * When checking issue reactions check the correct permission Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
techknowlogick
added
type/bug
topic/repo-migration
|
Closing this as Gitea migration isn't in 1.12 |
GiteaBot
added
the
lgtm/need 2
|
No but the reactions API is and it is those fixes which needs to be backported |
|
Ah yes. |
zeripath
reviewed
Oct 29, 2020
|
@zeripath those aren't included because |
techknowlogick
added
the
status/blocked
|
Adding blocked label |
|
Nope it's not that - unfortunately both the original and the 1.13 backport were missing one final change that I thought I had pushed up. Line 60 of the issue_reaction.go has the same bug and also needs to be fixed. |
Unfortunately my final push to go-gitea#13344 didn't register - or I failed to push it properly. GetIssueCommentReactions in routers/api/v1/repo/issue_reaction.go also makes the same mistake.
lunny
approved these changes
Oct 29, 2020
GiteaBot
added
lgtm/need 1
zeripath
removed
the
status/blocked
zeripath
approved these changes
Oct 29, 2020
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A failure during migrating reactions should not cause failure of
migration.
Signed-off-by: Andrew Thornton art27@cantab.net
Signed-off-by: Andrew Thornton art27@cantab.net
Credit @zeripath