Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 404 not 500 from API if team does not exist (#13118) #13119

Merged
merged 1 commit into from
Oct 12, 2020
Merged

Return 404 not 500 from API if team does not exist (#13118) #13119

merged 1 commit into from
Oct 12, 2020

Conversation

zeripath
Copy link
Contributor

Backport #13118

If team does not exist expect ErrTeamNotExist not ErrUserNotEXist

Fix #11336

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Return 404 not 500 from API if team does not exist (go-gitea#13118)
b650adc 
Backport go-gitea#13118

If team does not exist expect ErrTeamNotExist not ErrUserNotEXist

Fix go-gitea#11336

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.12.6 milestone Oct 12, 2020
6543
6543 approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the day of short-diff pulls ;)

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 12, 2020
@6543 6543 added the modifies/api This PR adds API routes or modifies them label Oct 12, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 12, 2020
@lafriks lafriks merged commit 09abdb8 into go-gitea:release/v1.12 Oct 12, 2020
@zeripath zeripath deleted the backport-13118 branch October 12, 2020 21:52
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug
Projects
None yet
Milestone
1.12.6
Development

Successfully merging this pull request may close these issues.
4 participants
@zeripath @lafriks @6543 @GiteaBot