Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 404 not 500 from API if team does not exist #13118

Merged
merged 2 commits into from
Oct 12, 2020
Merged

Return 404 not 500 from API if team does not exist #13118

merged 2 commits into from
Oct 12, 2020

Conversation

zeripath
Copy link
Contributor

If team does not exist expect ErrTeamNotExist not ErrUserNotEXist

Fix #11336

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Return 404 not 500 from API if team does not exist
2e5e55a 
If team does not exist expect ErrTeamNotExist not ErrUserNotEXist

Fix go-gitea#11336

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.13.0 milestone Oct 12, 2020
@6543 6543 added the modifies/api This PR adds API routes or modifies them label Oct 12, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 12, 2020
zeripath added a commit to zeripath/gitea that referenced this pull request Oct 12, 2020
@zeripath
Return 404 not 500 from API if team does not exist (go-gitea#13118)
b650adc 
Backport go-gitea#13118

If team does not exist expect ErrTeamNotExist not ErrUserNotEXist

Fix go-gitea#11336

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this pull request Oct 12, 2020
Merged
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 12, 2020
@lafriks
Copy link
Member

lafriks commented Oct 12, 2020

🚀

1 similar comment
@6543
Copy link
Member

6543 commented Oct 12, 2020

🚀

@techknowlogick techknowlogick merged commit f285860 into go-gitea:master Oct 12, 2020
@lafriks lafriks added the backport/done All backports for this PR have been created label Oct 12, 2020
lafriks pushed a commit that referenced this pull request Oct 12, 2020
@zeripath
Return 404 not 500 from API if team does not exist (#13118) (#13119)
09abdb8 
Backport #13118

If team does not exist expect ErrTeamNotExist not ErrUserNotEXist

Fix #11336

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath deleted the fix-11336-CheckErrTeamNotExist-not-User branch October 12, 2020 21:52
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Internal server errors on certain API requests
5 participants
@zeripath @lafriks @6543 @techknowlogick @GiteaBot