Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure RepoPath is lowercased in gitea serv #12668

Conversation

zeripath
Copy link
Contributor

#12624 missed lowering the provided repoPath.

(Additionally make a few fixes to the way the debug flag works.)

Fix #12659
Fix #12667

Signed-off-by: Andrew Thornton art27@cantab.net

go-gitea#12624 missed lowering the provided repoPath.

(Additionally make a few fixes to the way the debug flag works.)

Fix go-gitea#12659
Fix go-gitea#12667

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.13.0 milestone Aug 31, 2020
@zeripath
Copy link
Contributor Author

The changes to debug mean that you can actually run debug and push/pull without it breaking - apologies that I hadn't noticed that before.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 31, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 31, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 31, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #12668 into master will decrease coverage by 0.01%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12668      +/-   ##
==========================================
- Coverage   43.31%   43.30%   -0.02%     
==========================================
  Files         646      646              
  Lines       71588    71592       +4     
==========================================
- Hits        31010    31002       -8     
- Misses      35569    35576       +7     
- Partials     5009     5014       +5     
Impacted Files Coverage Δ
cmd/serv.go 2.08% <16.66%> (-0.78%) ⬇️
services/pull/update.go 51.92% <0.00%> (-5.77%) ⬇️
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
services/pull/temp_repo.go 26.59% <0.00%> (-3.20%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.54%) ⬇️
modules/log/event.go 56.60% <0.00%> (-0.95%) ⬇️
services/pull/pull.go 42.03% <0.00%> (-0.70%) ⬇️
modules/git/repo.go 49.23% <0.00%> (-0.51%) ⬇️
modules/queue/workerpool.go 60.00% <0.00%> (+1.22%) ⬆️
models/unit.go 49.31% <0.00%> (+2.73%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 807a41c...86fe045. Read the comment docs.

@zeripath zeripath merged commit 82b7188 into go-gitea:master Aug 31, 2020
@zeripath zeripath deleted the fix-12659-fix-12667-missing-to-lower-in-gitea-serv branch August 31, 2020 17:12
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
5 participants