Use shellquote to unpack arguments to gitea serv #12624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix go-gitea#12471 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
force-pushed
the
fix-12471-git-upload-pack-quoting
branch
from
6ccadbd
to
e5bc18f
Compare
GiteaBot
added
the
lgtm/need 2
Signed-off-by: Andrew Thornton <art27@cantab.net>
|
Damn I always forget to run golangci-lint as it makes my laptop jump to 100°C and puts the fans on max. I don't quite understand why... |
Codecov Report
@@ Coverage Diff @@
## master #12624 +/- ##
==========================================
+ Coverage 43.43% 43.45% +0.01%
==========================================
Files 645 645
Lines 71328 71328
==========================================
+ Hits 30983 30995 +12
+ Misses 35332 35324 -8
+ Partials 5013 5009 -4
Continue to review full report at Codecov.
|
techknowlogick
approved these changes
Aug 28, 2020
GiteaBot
added
lgtm/need 1
mrsdizzie
approved these changes
Aug 28, 2020
GiteaBot
added
lgtm/done
7 tasks
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Aug 31, 2020
go-gitea#12624 missed lowering the provided repoPath. (Additionally make a few fixes to the way the debug flag works.) Fix go-gitea#12659 Fix go-gitea#12667 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added a commit
that referenced
this pull request
Aug 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12471
Signed-off-by: Andrew Thornton art27@cantab.net