Skip to content

Conversation

@zeripath
Copy link
Contributor

If the user has pressed commit changes and the post has failed - do not disable
the commit changes button.

Fix #12072

Signed-off-by: Andrew Thornton art27@cantab.net

If the user has pressed commit changes and the post has failed - do not disable
the commit changes button.

Fix go-gitea#12072

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.13.0 milestone Aug 29, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #12644 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12644      +/-   ##
==========================================
+ Coverage   43.43%   43.44%   +0.01%     
==========================================
  Files         645      645              
  Lines       71328    71329       +1     
==========================================
+ Hits        30981    30991      +10     
+ Misses      35333    35326       -7     
+ Partials     5014     5012       -2     
Impacted Files Coverage Δ
routers/repo/editor.go 25.14% <100.00%> (+0.14%) ⬆️
modules/indexer/stats/queue.go 64.70% <0.00%> (-11.77%) ⬇️
models/gpg_key.go 54.81% <0.00%> (-0.59%) ⬇️
modules/git/repo.go 49.74% <0.00%> (+0.50%) ⬆️
modules/log/event.go 57.54% <0.00%> (+0.94%) ⬆️
modules/queue/unique_queue_disk_channel.go 55.38% <0.00%> (+1.53%) ⬆️
modules/queue/workerpool.go 62.04% <0.00%> (+2.04%) ⬆️
modules/git/utils.go 77.04% <0.00%> (+3.27%) ⬆️
modules/indexer/stats/db.go 60.86% <0.00%> (+8.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7187fdb...2225bd3. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 29, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 29, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 29, 2020
@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit 17fbbe9 into go-gitea:master Aug 29, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Commit button stays disabled when summary initally was > 100 chars

6 participants