Commit button stays disabled when summary initally was > 100 chars

[ashimokawa]

• Gitea version (or commit ref): 1.12.1
• Git version: 2.20.1
• Operating system: Debian 10
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist:

Description

When editing a file in the web GUI and trying to commit with a commit summary of > 100 characters, the commit button gets disabled and stays disabled even when shortening the summary afterwards. Workaround is to remove the disabled attribute from the button in the browser DOM inspector.

Originally reported here: https://codeberg.org/Codeberg/Community/issues/207

Screenshots

[stale]

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

[zeripath]

The problem lies in index.js within async function initEditor() {...}

gitea/web_src/js/index.js

Line 1595 in 7187fdb

$commitButton.prop('disabled', true);

This line disables the commit button by default. I suspect that on post with error we should just not disable this button.