Skip to content

Fixes #12341: Release date should only be set to current time if draft or tag created #12343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jul 28, 2020
Merged

Fixes #12341: Release date should only be set to current time if draft or tag created #12343

merged 14 commits into from
Jul 28, 2020

Conversation

@richmahn
Copy link
Contributor

@richmahn richmahn commented Jul 27, 2020

We should only change the created_unix of a release when the tag is made or if it is a draft. Currently it changes it whenever any edit is done to the release.

@richmahn
Copy link
Contributor Author

richmahn commented Jul 27, 2020

Will make backport to 1.12

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 27, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 27, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Jul 27, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 27, 2020
@silverwind
Copy link
Member

silverwind commented Jul 27, 2020

Need to make fmt.

6543
6543 approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests 😍

@richmahn
Copy link
Contributor Author

richmahn commented Jul 28, 2020

@silverwind Looks like @techknowlogick did it for me. Was going to do that this morning. Noticed the stray commas when looking at why my tests were failing.

So @techknowlogick, I fixed the tests. Waiting for build.

richmahn added a commit to richmahn/gitea that referenced this pull request Jul 28, 2020
@richmahn
Backport for Issue go-gitea#12341 PR go-gitea#12343 - Release date fix
4f13140
@richmahn richmahn mentioned this pull request Jul 28, 2020
Merged
@richmahn
Copy link
Contributor Author

richmahn commented Jul 28, 2020

@silverwind I make fmt all the time, especially in my company's fork of Gitea, yet I still get unformatted code in my commits. I can't win! LOL

@zeripath
Copy link
Contributor

zeripath commented Jul 28, 2020

@richmahn the results of go fmt can differ between different versions of go - if you're not running the same version of go as drone you may find that this is a problem.

I've never had to run make fmt explicitly what editor are you using?

@richmahn
Copy link
Contributor Author

richmahn commented Jul 28, 2020

@zeripath What do you mean by running it explicitly? Do your IDE format whatever you write after you change lines? I use GoLand, even though I want to use VSCode but never successfully got it to build and run tests.

@jolheiser
Copy link
Member

jolheiser commented Jul 28, 2020

I believe both GoLand and VSCode can automatically format saved files (or however they are configured to watch).

@richmahn
Copy link
Contributor Author

richmahn commented Jul 28, 2020

@jolheiser Hmm, ok, will have to look into how to configure it. I have done that in VSCode for Javascript before.

@6543
Copy link
Member

6543 commented Jul 28, 2020

I prevere a make fmt befor commiting, so code is not flowing around while typing

@6543
Copy link
Member

6543 commented Jul 28, 2020

... I make fmt all the time, especially in my company's fork of Gitea, yet I still get unformatted code in my commits. I can't win! LOL

don't know how this can happen, do you use the IDE to do git stuff?

@techknowlogick
Copy link
Member

techknowlogick commented Jul 28, 2020

🚀

@techknowlogick techknowlogick merged commit 8a36c46 into go-gitea:master Jul 28, 2020
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Jul 28, 2020
techknowlogick pushed a commit that referenced this pull request Jul 28, 2020
@richmahn
Backport to v1.12 for #12341 - Release date fix (#12351)
87bfe02 
* Backport for Issue #12341 PR #12343 - Release date fix

* Adds sleep for comparing times

* Fixes imports

* Fixes tests
@techknowlogick techknowlogick mentioned this pull request Jul 28, 2020
Merged
@mrsdizzie mrsdizzie mentioned this pull request Sep 7, 2020
Closed
4 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@6543 6543 6543 approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.13.0

Development

Successfully merging this pull request may close these issues.

7 participants

@richmahn @silverwind @zeripath @jolheiser @6543 @techknowlogick @GiteaBot