-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Force-update in Mirror and improve Tracing in mirror #12242
Support Force-update in Mirror and improve Tracing in mirror #12242
Conversation
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
small nit but otherwise lgtm |
@zeripath there should be an option to enable/disable force-update on mirrors since it could be an eavel atack to delete code some mirrors exist to have a copy of some code (prevent code erase of eavil actions witch could happen on opencource repos) |
@6543 git is doing the mirroring not us - so the force update already happens - the issue is that the gitea UI doesn't get updated. |
ok konssider this pull as bugfix (as lable already indecate) and my comment as new feature-request |
Codecov Report
@@ Coverage Diff @@
## master #12242 +/- ##
=======================================
Coverage 43.50% 43.51%
=======================================
Files 642 642
Lines 71013 71040 +27
=======================================
+ Hits 30893 30910 +17
- Misses 35113 35123 +10
Partials 5007 5007
Continue to review full report at Codecov.
|
This PR allows the mirror service to handle force-updates and improves Trace logging within the mirror service considerably.
It also fixes a bug in
log.NewColoredIDValue()
which led to a double indirection and incorrect IDs being printed out.