Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix double-indirection bug in logging IDs #12294

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Fix double-indirection bug in logging IDs #12294

merged 1 commit into from
Jul 23, 2020

Conversation

zeripath
Copy link
Contributor

This PR fixes a bug in log.NewColoredIDValue() which led to a double
indirection and incorrect IDs being printed out.

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Fix double-indirection bug in logging IDs
a29e10c 
This PR fixes a bug in log.NewColoredIDValue() which led to a double
indirection and incorrect IDs being printed out.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.13.0 milestone Jul 22, 2020
@zeripath
Copy link
Contributor Author

Found and initially fixed in #12242

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 22, 2020
@zeripath zeripath mentioned this pull request Jul 22, 2020
Merged
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 22, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 23, 2020
@lafriks lafriks merged commit d25f442 into go-gitea:master Jul 23, 2020
@lafriks
Copy link
Member

lafriks commented Jul 23, 2020

Please send backport

techknowlogick pushed a commit to techknowlogick/gitea that referenced this pull request Jul 23, 2020
@zeripath @techknowlogick
Fix double-indirection bug in logging IDs (go-gitea#12294)
00488b9 
This PR fixes a bug in log.NewColoredIDValue() which led to a double
indirection and incorrect IDs being printed out.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Jul 23, 2020
@techknowlogick techknowlogick mentioned this pull request Jul 23, 2020
Merged
lafriks pushed a commit that referenced this pull request Jul 23, 2020
@techknowlogick @zeripath
Fix double-indirection bug in logging IDs (#12294) (#12308)
8d1cd4d 
This PR fixes a bug in log.NewColoredIDValue() which led to a double
indirection and incorrect IDs being printed out.

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: zeripath <art27@cantab.net>
@zeripath zeripath deleted the fix-poor-bug-in-id-rendering branch July 27, 2020 21:07
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrsdizzie mrsdizzie mrsdizzie approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@zeripath @lafriks @mrsdizzie @techknowlogick @GiteaBot