Add team support for review request #12039

a1012112796 · 2020-06-24T14:22:40Z

As title.
Block #11355

Block go-gitea#11355 Signed-off-by: a1012112796 <1012112796@qq.com>

igalic · 2020-07-25T11:50:41Z

will this allow me to request changes to a review i opened, but that I'm actually coöperating with other people?

6543 · 2020-08-24T10:33:41Z

Pleace dont do too mouch in one pull - split them up and it's easyer to maintain

a1012112796 · 2020-08-24T11:39:57Z

Pleace dont do too mouch in one pull - split them up and it's easyer to maintain

I haven't did other thing ... 🤔

6543 · 2020-08-24T11:43:53Z

@a1012112796 : I'd like to wait #12039 to do more things. on #11355 (comment)

models/repo.go

codecov-commenter · 2020-09-13T09:58:02Z

Codecov Report

Merging #12039 into master will decrease coverage by 0.01%.
The diff coverage is 22.70%.

@@            Coverage Diff             @@
##           master   #12039      +/-   ##
==========================================
- Coverage   42.52%   42.50%   -0.02%     
==========================================
  Files         672      673       +1     
  Lines       73785    74126     +341     
==========================================
+ Hits        31374    31506     +132     
- Misses      37340    37508     +168     
- Partials     5071     5112      +41

Impacted Files	Coverage Δ
models/migrations/migrations.go	`2.46% <ø> (ø)`
models/migrations/v153.go	`0.00% <0.00%> (ø)`
services/issue/assignee.go	`21.15% <0.00%> (-12.18%)`	⬇️
models/issue_comment.go	`52.93% <7.14%> (+6.53%)`	⬆️
models/review.go	`35.23% <14.74%> (-10.86%)`	⬇️
routers/repo/issue.go	`36.07% <30.11%> (-0.79%)`	⬇️
models/repo.go	`55.21% <63.15%> (+0.05%)`	⬆️
services/pull/check.go	`48.46% <0.00%> (-4.62%)`	⬇️
services/pull/temp_repo.go	`26.59% <0.00%> (-3.20%)`	⬇️
services/pull/patch.go	`66.37% <0.00%> (-2.59%)`	⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df4bbcd...7d75af0. Read the comment docs.

lafriks

Imho it would be better to add new column AssigneeTeamID than reuse same field with negative values. If we later finally implement foreign keys in database this will backfire

lafriks · 2020-09-27T21:07:53Z

Please resolve conflicts

models/migrations/v153.go

Co-authored-by: Lauris BH <lauris@nix.lv>

models/repo.go

templates/repo/issue/view_content/sidebar.tmpl

* Fix getReviewers() return * Simplify ui logic * Fix some bugs about Original author

models/repo.go

zeripath · 2020-10-12T09:42:53Z

OK I just need to test this.

zeripath · 2020-10-12T09:53:58Z

Hmm... just tried to remove a request for administrator to review and got the following error:

2020/10/12 10:52:27 ...outers/repo/issue.go:1891:UpdatePullReviewRequest() [W] UpdatePullReviewRequest: refusing to add invalid review request for 1:administrator to 44:adminOrg/ToFork#1: Error: sql: expected 13 destination arguments in Scan, not 1

a1012112796 · 2020-10-12T13:16:05Z

Hmm... just tried to remove a request for administrator to review and got the following error:

2020/10/12 10:52:27 ...outers/repo/issue.go:1891:UpdatePullReviewRequest() [W] UpdatePullReviewRequest: refusing to add invalid review request for 1:administrator to 44:adminOrg/ToFork#1: Error: sql: expected 13 destination arguments in Scan, not 1

@zeripath fixed

6543 · 2020-10-12T13:17:13Z

this pull is now also a bugfix 😆, if fix #12878

models/review.go

6543

code looks nice, it fix a bug and works

6543 · 2020-10-12T13:27:50Z

I think it still should get @zeripath review :)

templates/repo/issue/view_content/sidebar.tmpl

zeripath

I also think it would look a bit better with a team icon shown

templates/repo/issue/view_content/sidebar.tmpl

Signed-off-by: Andrew Thornton <art27@cantab.net>

zeripath

I don't know what happened. I managed to somehow end up with reviewers being disabled but I don't know how and I can't replicate it now. So I'm approving.

6543

call it team work - for team review 👍

6543 · 2020-10-12T18:56:27Z

🚀

lafriks · 2020-10-12T19:24:43Z

🚀

follow go-gitea#12039, show original author's reviews by other way. fix go-gitea#11705. Signed-off-by: a1012112796 <1012112796@qq.com>

follow #12039, show original author's reviews by other way. fix #11705. Signed-off-by: a1012112796 <1012112796@qq.com>

a1012112796 added 3 commits June 20, 2020 18:40

Add team support for review request

cfa6db7

Block go-gitea#11355 Signed-off-by: a1012112796 <1012112796@qq.com>

Merge branch 'master' into team_review_request

0501111

fix lint

3196c8e

lafriks added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Jun 25, 2020

lafriks added this to the 1.13.0 milestone Jun 25, 2020

a1012112796 mentioned this pull request Jul 8, 2020

support Github-like CODEOWNERS? #10161

Closed

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 25, 2020

a1012112796 mentioned this pull request Aug 24, 2020

Add review request api #11355

Merged

6543 reviewed Sep 12, 2020

View reviewed changes

models/repo.go Outdated Show resolved Hide resolved

a1012112796 added 2 commits September 13, 2020 17:05

Merge branch 'master' into team_review_request

8e37106

Apply review suggestion

3c02d48

lafriks reviewed Sep 14, 2020

View reviewed changes

a1012112796 added 3 commits September 16, 2020 21:05

Merge branch 'master' into team_review_request

df750f5

Apply suggestion from review @lafriks

fbef6d7

fix lint

66a0f47

Merge branch 'master' into team_review_request

3685fc6

lafriks reviewed Sep 28, 2020

View reviewed changes

models/migrations/v153.go Outdated Show resolved Hide resolved

Update models/migrations/v153.go

f36a5ec

Co-authored-by: Lauris BH <lauris@nix.lv>

lafriks requested changes Sep 28, 2020

View reviewed changes

models/repo.go Outdated Show resolved Hide resolved

templates/repo/issue/view_content/sidebar.tmpl Outdated Show resolved Hide resolved

a1012112796 added 4 commits September 29, 2020 13:08

Apply suggestion from code review @lafriks

26eb8c4

* Fix getReviewers() return * Simplify ui logic * Fix some bugs about Original author

Merge branch 'master' into team_review_request

a6b94f6

fix lint

515d09d

fix test

3f8fee5

lafriks reviewed Oct 5, 2020

View reviewed changes

models/repo.go Outdated Show resolved Hide resolved

a1012112796 added 2 commits October 12, 2020 21:02

fix bugs

b13cad0

Merge branch 'master' into team_review_request

c0a29f7

6543 added the type/bug label Oct 12, 2020

a1012112796 commented Oct 12, 2020

View reviewed changes

models/review.go Outdated Show resolved Hide resolved

Update models/review.go

0b909f9

6543 approved these changes Oct 12, 2020

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 12, 2020

Merge branch 'master' into team_review_request

857f5de

zeripath suggested changes Oct 12, 2020

View reviewed changes

templates/repo/issue/view_content/sidebar.tmpl Show resolved Hide resolved

zeripath reviewed Oct 12, 2020

View reviewed changes

templates/repo/issue/view_content/sidebar.tmpl Outdated Show resolved Hide resolved

templates/repo/issue/view_content/sidebar.tmpl Outdated Show resolved Hide resolved

templates/repo/issue/view_content/sidebar.tmpl Outdated Show resolved Hide resolved

Add octicon-people to the team reviews

e5d3c88

Signed-off-by: Andrew Thornton <art27@cantab.net>

zeripath approved these changes Oct 12, 2020

View reviewed changes

6543 approved these changes Oct 12, 2020

View reviewed changes

Merge branch 'master' into team_review_request

9da446e

zeripath changed the title ~~[Enhancement] Add team support for review request~~ Add team support for review request Oct 12, 2020

zeripath merged commit 8be3e43 into go-gitea:master Oct 12, 2020

6543 mentioned this pull request Oct 12, 2020

Re-request review do not work #12878

Closed

7 tasks

a1012112796 added a commit to a1012112796/gitea that referenced this pull request Oct 13, 2020

Show original author's reviews on pull summary box

b5b608c

follow go-gitea#12039, show original author's reviews by other way. fix go-gitea#11705. Signed-off-by: a1012112796 <1012112796@qq.com>

a1012112796 deleted the team_review_request branch October 13, 2020 10:48

a1012112796 mentioned this pull request Oct 13, 2020

Show original author's reviews on pull summary box #13127

Merged

zeripath pushed a commit that referenced this pull request Oct 14, 2020

Show original author's reviews on pull summary box (#13127)

9798014

follow #12039, show original author's reviews by other way. fix #11705. Signed-off-by: a1012112796 <1012112796@qq.com>

go-gitea locked and limited conversation to collaborators Nov 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add team support for review request #12039

Add team support for review request #12039

a1012112796 commented Jun 24, 2020 •

edited

Loading

igalic commented Jul 25, 2020

6543 commented Aug 24, 2020

a1012112796 commented Aug 24, 2020

6543 commented Aug 24, 2020

codecov-commenter commented Sep 13, 2020 •

edited

Loading

lafriks left a comment

lafriks commented Sep 27, 2020

zeripath commented Oct 12, 2020

zeripath commented Oct 12, 2020

a1012112796 commented Oct 12, 2020

6543 commented Oct 12, 2020

6543 left a comment

6543 commented Oct 12, 2020

zeripath left a comment

zeripath left a comment •

edited

Loading

6543 left a comment •

edited

Loading

6543 commented Oct 12, 2020

lafriks commented Oct 12, 2020

Add team support for review request #12039

Add team support for review request #12039

Conversation

a1012112796 commented Jun 24, 2020 • edited Loading

igalic commented Jul 25, 2020

6543 commented Aug 24, 2020

a1012112796 commented Aug 24, 2020

6543 commented Aug 24, 2020

codecov-commenter commented Sep 13, 2020 • edited Loading

Codecov Report

lafriks left a comment

Choose a reason for hiding this comment

lafriks commented Sep 27, 2020

zeripath commented Oct 12, 2020

zeripath commented Oct 12, 2020

a1012112796 commented Oct 12, 2020

6543 commented Oct 12, 2020

6543 left a comment

Choose a reason for hiding this comment

6543 commented Oct 12, 2020

zeripath left a comment

Choose a reason for hiding this comment

zeripath left a comment • edited Loading

Choose a reason for hiding this comment

6543 left a comment • edited Loading

Choose a reason for hiding this comment

6543 commented Oct 12, 2020

lafriks commented Oct 12, 2020

a1012112796 commented Jun 24, 2020 •

edited

Loading

codecov-commenter commented Sep 13, 2020 •

edited

Loading

zeripath left a comment •

edited

Loading

6543 left a comment •

edited

Loading