Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird behavior when migrating from Github to gitea.com #11705

Closed
1 of 3 tasks
j-be opened this issue May 31, 2020 · 4 comments · Fixed by #13127
Closed
1 of 3 tasks

Weird behavior when migrating from Github to gitea.com #11705

j-be opened this issue May 31, 2020 · 4 comments · Fixed by #13127
Labels
issue/stale type/bug

Comments

@j-be
Copy link

j-be commented May 31, 2020

  • Gitea version (or commit ref): 1.13.0+dev-30-gb02d2c377
  • Git version: whatever gitea.com runs on
  • Operating system: whatever gitea.com runs on
  • Database (use [x]): whatever gitea.com runs on
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant

Description

While working on #8380 I migrated https://github.com/go-gitea/test_repo to https://gitea.com/j-be/test_repo/ and took that for unit tests. I am now a bit confused on how some stuff is handled when migrating:

  • Reactions:

    • lunny is taken over as UserID: 1, UserName: "lunny", as that user exists on Gitea too
    • mrsdizzie as user in Reactions is migrated as UserID: -1, UserName: "mrsdizzie(github)", which looks really good in the UI, but mrsdizzie would exist on Gitea as well - I guess OIDC is involved here, but how does it know? Do I need to take into account something here as well?

  • Review - here is where it gets really confusing:

    • lunny and jolheiser are both taken over as ReviewerID: 0, even though the accounts would exist on gitea.com
    • Reviews from both zeripath and lafriks are suddenly mine (ReviewerID: 5610, ReviewerName: "j-be"), again, even though these users exist on gitea.com

  • Release, PullRequest, and Comments thereof are all PublisherID: 5610, PublisherName: "j-be" and PosterID: 5610, PosterName: "j-be", even though they should still be owned by their initial authors.
@j-be j-be mentioned this issue May 31, 2020
Closed
7 tasks
@lunny
Copy link
Member

lunny commented Jun 1, 2020

Because lunny on gitea.com (that's me :)) has binding github login, so we can replace the external account as an internal account, but mrsdizzie hasn't binding github login, so It displayed as external account.

@lunny
Copy link
Member

lunny commented Jun 1, 2020 •
edited
Loading

图片

It should be some bug.

@lunny lunny added the type/bug label Jun 1, 2020
a1012112796 added a commit to a1012112796/gitea that referenced this issue Jun 1, 2020
@a1012112796
bug: fix wrong poster message for code comment on Pull view
7fa60e0 
As title, maybe fix one of issue in go-gitea#11705

Signed-off-by: a1012112796 <1012112796@qq.com>
@a1012112796 a1012112796 mentioned this issue Jun 1, 2020
Merged
a1012112796 added a commit to a1012112796/gitea that referenced this issue Jun 1, 2020
@a1012112796
bug: fix summary box for reviewrs
7b4cb1a 
fix one part of go-gitea#11705

Signed-off-by: a1012112796 <1012112796@qq.com>
@a1012112796 a1012112796 mentioned this issue Jun 1, 2020
Closed
techknowlogick added a commit that referenced this issue Jun 3, 2020
@a1012112796 @techknowlogick
bug: fix wrong poster message for code comment on Pull view (#11721)
de0b2d4 
As title, maybe fix one of issue in #11705

Signed-off-by: a1012112796 <1012112796@qq.com>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
j-be added a commit to j-be/gitea that referenced this issue Jun 6, 2020
@j-be
[UnitTest] Swap out lunny's ID.
9d4a395 
Telling from the response on go-gitea#11705 this is expected.

Signed-off-by: Juri Berlanda <juriberlanda@hotmail.com>
j-be added a commit to j-be/gitea that referenced this issue Jun 6, 2020
@j-be
[UnitTest] Use "mrsdizzie(github)" where applicable.
14c3805 
Telling from the response on go-gitea#11705 this is expected.

Signed-off-by: Juri Berlanda <juriberlanda@hotmail.com>
@stale
Copy link

stale bot commented Jul 31, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Jul 31, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this issue Jul 31, 2020
@a1012112796 @techknowlogick
bug: fix wrong poster message for code comment on Pull view (go-gitea…
a797c15 
…#11721)

As title, maybe fix one of issue in go-gitea#11705

Signed-off-by: a1012112796 <1012112796@qq.com>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@stale
Copy link

stale bot commented Aug 16, 2020

This issue has been automatically closed because of inactivity. You can re-open it if needed.

@stale stale bot closed this as completed Aug 16, 2020
@a1012112796 a1012112796 mentioned this issue Oct 7, 2020
Merged
a1012112796 added a commit to a1012112796/gitea that referenced this issue Oct 13, 2020
@a1012112796
Show original author's reviews on pull summary box
b5b608c 
follow go-gitea#12039, show original author's reviews by other way.
fix go-gitea#11705.

Signed-off-by: a1012112796 <1012112796@qq.com>
@a1012112796 a1012112796 mentioned this issue Oct 13, 2020
Merged
zeripath pushed a commit that referenced this issue Oct 14, 2020
@a1012112796
Show original author's reviews on pull summary box (#13127)
9798014 
follow #12039, show original author's reviews by other way.
fix #11705.

Signed-off-by: a1012112796 <1012112796@qq.com>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/stale type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show original author's reviews on pull summary box a1012112796/gitea
2 participants
@lunny @j-be