Skip to content

Fix top margin for bottom attached header #11480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2020
Merged

Fix top margin for bottom attached header #11480

merged 1 commit into from
May 18, 2020

Conversation

@CirnoT
Copy link
Contributor

@CirnoT CirnoT commented May 18, 2020

Introduced by #10235

Before:
chrome_2020-05-18_10-29-58

After:
chrome_2020-05-18_10-30-14

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 18, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 18, 2020
@zeripath zeripath merged commit 6b798fe into go-gitea:master May 18, 2020
@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label May 18, 2020
@zeripath zeripath added this to the 1.13.0 milestone May 18, 2020
@CirnoT CirnoT deleted the margin-attached-bottom branch May 18, 2020 13:33
CirnoT added a commit to CirnoT/gitea that referenced this pull request May 18, 2020
@CirnoT
Fix top margin for bottom attached header (go-gitea#11480)
bc297a4 
(cherry picked from commit 6b798fe)
@CirnoT CirnoT mentioned this pull request May 18, 2020
Merged
@lafriks lafriks added the backport/done All backports for this PR have been created label May 18, 2020
techknowlogick pushed a commit that referenced this pull request May 19, 2020
@CirnoT @lafriks
Fix top margin for bottom attached header (#11480) (#11485)
1547ce5 
* Fix top margin for bottom attached header (#11480)

(cherry picked from commit 6b798fe)

* restart ci

Co-authored-by: Lauris BH <lauris@nix.lv>
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@CirnoT
Fix top margin for bottom attached header (go-gitea#11480)
81727e1
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@silverwind silverwind silverwind approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI

Projects

None yet

Milestone

1.13.0

Development

Successfully merging this pull request may close these issues.

5 participants

@CirnoT @silverwind @zeripath @lafriks @GiteaBot