Skip to content

fix margin on attached segments with headers #10235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 12, 2020
Merged

fix margin on attached segments with headers #10235

merged 3 commits into from
Feb 12, 2020

Conversation

@silverwind
Copy link
Member

@silverwind silverwind commented Feb 11, 2020

Fixes: #10210

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 11, 2020
@codecov-io
Copy link

codecov-io commented Feb 11, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@06d519e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10235   +/-   ##
=========================================
  Coverage          ?   43.66%           
=========================================
  Files             ?      582           
  Lines             ?    80047           
  Branches          ?        0           
=========================================
  Hits              ?    34951           
  Misses            ?    40761           
  Partials          ?     4335

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06d519e...16cc94d. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 11, 2020
@lafriks
Copy link
Member

lafriks commented Feb 11, 2020

Conflict

@lafriks lafriks added topic/ui Change the appearance of the Gitea UI skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Feb 11, 2020
@silverwind
Copy link
Member Author

silverwind commented Feb 11, 2020

Resolved

@lafriks lafriks added this to the 1.12.0 milestone Feb 11, 2020
@techknowlogick techknowlogick merged commit ea7ad38 into go-gitea:master Feb 12, 2020
This was referenced May 15, 2020
Merged
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks approved these changes

@jolheiser jolheiser jolheiser approved these changes

+1 more reviewer

@guillep2k guillep2k guillep2k approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI

Projects

None yet

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

Possible visual bug: There is no margin between div elements anymore

7 participants

@silverwind @codecov-io @lafriks @guillep2k @jolheiser @techknowlogick @GiteaBot