Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long commit message hides commit status icon #7180

Closed
2 of 7 tasks
timothyqiu opened this issue Jun 11, 2019 · 3 comments · Fixed by #7190
Closed
2 of 7 tasks

Long commit message hides commit status icon #7180

timothyqiu opened this issue Jun 11, 2019 · 3 comments · Fixed by #7190
Labels
topic/ui Change the appearance of the Gitea UI

Comments

@timothyqiu
Copy link

  • Gitea version (or commit ref): 1.8.2
  • Git version: 2.11.0
  • Operating system: Debian 9.9
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant

Description

In the commits table (both in commits and pull request page), the commit status icon will be hidden if the commit message is too long.

I think the commit status icon is not part of the commit message. It'll be better if the icon is always shown.

Screenshots

The long commit message is truncated with ellipsis, hiding the commit status icon.
truncated

Narrow the browser, and the commit status icon appears.
narrow
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Jun 11, 2019
@belliash
Copy link

I agree, icon should be always seen. Sometimes, the message is not cut and the "..." link is shown instead of icon.

@silverwind
Copy link
Member

How does one get such a status icon? Does it need a CI?

@jolheiser
Copy link
Member

@silverwind https://try.gitea.io/api/v1/swagger#/repository/repoCreateStatus
I believe both Drone and Jenkins plugins use the endpoint.

silverwind added a commit to silverwind/gitea that referenced this issue Jun 12, 2019
@silverwind
UI: Fix overflow issues in repo
70172dc 
- Fix layout overflow in repo file list.
- Fix invisible status icon in file view and commit list. In file view,
  the icon was moved to the left because I could not figure out a proper
  fix because of HTML tables.
- Added title attribute to commit messages.
- Fixed two CSS linter warnings in existing CSS.
- Fixed CI variable check in 'make css'.

Fixes: go-gitea#7180
@silverwind silverwind mentioned this issue Jun 12, 2019
Merged
lunny pushed a commit that referenced this issue Jun 14, 2019
@silverwind @lunny
UI: Fix overflow issues in repo (#7190)
9ce4d89 
- Fix layout overflow in repo file list.
- Fix invisible status icon in file view and commit list. In file view,
  the icon was moved to the left because I could not figure out a proper
  fix because of HTML tables.
- Added title attribute to commit messages.
- Fixed two CSS linter warnings in existing CSS.
- Fixed CI variable check in 'make css'.

Fixes: #7180
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this issue Jul 18, 2019
@silverwind @jeffliu27
UI: Fix overflow issues in repo (go-gitea#7190)
6336cf7 
- Fix layout overflow in repo file list.
- Fix invisible status icon in file view and commit list. In file view,
  the icon was moved to the left because I could not figure out a proper
  fix because of HTML tables.
- Added title attribute to commit messages.
- Fixed two CSS linter warnings in existing CSS.
- Fixed CI variable check in 'make css'.

Fixes: go-gitea#7180
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

UI: Fix overflow issues in repo silverwind/gitea
5 participants
@lunny @silverwind @timothyqiu @belliash @jolheiser