Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix overflow issues in repo #7190

Merged
merged 4 commits into from
Jun 14, 2019
Merged

Conversation

silverwind
Copy link
Member

  • Fix layout overflow in repo file list.
  • Fix invisible status icon in file view and commit list. In file view, the icon was moved to the left because I could not figure out a proper fix because of HTML tables.
  • Added title attribute to commit messages.
  • Fixed two CSS linter warnings in existing CSS.
  • Fixed CI variable check in 'make css'.

Fixes: #7180

Screenshots:

- Fix layout overflow in repo file list.
- Fix invisible status icon in file view and commit list. In file view,
  the icon was moved to the left because I could not figure out a proper
  fix because of HTML tables.
- Added title attribute to commit messages.
- Fixed two CSS linter warnings in existing CSS.
- Fixed CI variable check in 'make css'.

Fixes: go-gitea#7180
@techknowlogick techknowlogick added type/bug topic/ui Change the appearance of the Gitea UI labels Jun 12, 2019
@techknowlogick techknowlogick added this to the 1.9.0 milestone Jun 12, 2019
@silverwind
Copy link
Member Author

If anyone has a better idea on how to get the icon (and text-overflow) to work correctly on the right side of the file view header, shoot. Couldn't figure it out while testing with Firefox. I imagine it being easier to fix in Chrome as it seems to handle text overflow in tables quite differently than Firefox (which for some reason falls back to display no text at all in some cases).

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 12, 2019
@silverwind
Copy link
Member Author

Thinking about maybe truncating the commit line to 50 or 72 chars before rendering and making sure the UI has enough space for that so we don't have to rely on wonky CSS-based truncation.

@mrsdizzie
Copy link
Member

Looks like Github cuts off at 70 characters(plus an ellipse) which seems reasonable for this.

@codecov-io
Copy link

codecov-io commented Jun 12, 2019

Codecov Report

Merging #7190 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7190      +/-   ##
==========================================
- Coverage   41.53%   41.52%   -0.01%     
==========================================
  Files         449      449              
  Lines       61306    61306              
==========================================
- Hits        25462    25456       -6     
- Misses      32490    32497       +7     
+ Partials     3354     3353       -1
Impacted Files Coverage Δ
models/unit.go 62.16% <0%> (-5.41%) ⬇️
routers/repo/view.go 42.23% <0%> (-1.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f39fc7...62616c9. Read the comment docs.

@silverwind
Copy link
Member Author

Yeah, will look into doing that, so please consider this PR a WIP.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 13, 2019
@lafriks
Copy link
Member

lafriks commented Jun 13, 2019

Imho that character limit can be done in other PR

@silverwind
Copy link
Member Author

Feel free to merge this now. I will follow up with another PR that does the truncation and moves the icon in the file table to the right again later.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 13, 2019
@lunny lunny merged commit 9ce4d89 into go-gitea:master Jun 14, 2019
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
- Fix layout overflow in repo file list.
- Fix invisible status icon in file view and commit list. In file view,
  the icon was moved to the left because I could not figure out a proper
  fix because of HTML tables.
- Added title attribute to commit messages.
- Fixed two CSS linter warnings in existing CSS.
- Fixed CI variable check in 'make css'.

Fixes: go-gitea#7180
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long commit message hides commit status icon
8 participants