Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort dropdown flashes when loading issue/pr list #23857

Closed
silverwind opened this issue Apr 1, 2023 · 6 comments · Fixed by #23856
Closed

Sort dropdown flashes when loading issue/pr list #23857

silverwind opened this issue Apr 1, 2023 · 6 comments · Fixed by #23856
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Milestone

Comments

@silverwind
Copy link
Member

silverwind commented Apr 1, 2023

Description

When viewing the issue or pr list, there is a short flash of the sort dropdown content.

Can you reproduce the bug on the Gitea demo site?

Yes

@silverwind silverwind added type/bug topic/ui Change the appearance of the Gitea UI labels Apr 1, 2023
@silverwind
Copy link
Member Author

silverwind commented Apr 1, 2023

1.19 is not affected, so this is a very recent regression. @wxiaoguang might have been from one of your recent PRs.

@silverwind silverwind added this to the 1.20.0 milestone Apr 1, 2023
@wxiaoguang
Copy link
Contributor

I guess it's related to

the initial purpose is for:

let me see

@wxiaoguang
Copy link
Contributor

Removing the "left" style of the "menu" resolves the flash. If you don't mind, I will make the fix in #23856 together, to save time.

@silverwind
Copy link
Member Author

Don't mind, but there might be more similar cases, should grep for them.

@silverwind
Copy link
Member Author

Actually, I do mind a bit as there is no relation, so separate PR might be good :)

@wxiaoguang
Copy link
Contributor

Don't mind, but there might be more similar cases, should grep for them.

Nope, there won't. The whole story is:

Since the popup position calculation is not stable, so I think it's good to make the "Sort" menu always have the "left" position. However, the "left" style have "display: flex", it should be used with "hidden" together. I didn't find the flash because my window is not large enough during my test. To make things simple, remove the "left" style.

So, it's a simple fix. I just pushed ... and I will update the description.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants