-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort dropdown flashes when loading issue/pr list #23857
Comments
1.19 is not affected, so this is a very recent regression. @wxiaoguang might have been from one of your recent PRs. |
I guess it's related to the initial purpose is for: let me see |
Removing the "left" style of the "menu" resolves the flash. If you don't mind, I will make the fix in #23856 together, to save time. |
Don't mind, but there might be more similar cases, should grep for them. |
Actually, I do mind a bit as there is no relation, so separate PR might be good :) |
Nope, there won't. The whole story is: Since the popup position calculation is not stable, so I think it's good to make the "Sort" menu always have the "left" position. However, the "left" style have "display: flex", it should be used with "hidden" together. I didn't find the flash because my window is not large enough during my test. To make things simple, remove the "left" style. So, it's a simple fix. I just pushed ... and I will update the description. |
Description
When viewing the issue or pr list, there is a short flash of the sort dropdown content.
Can you reproduce the bug on the Gitea demo site?
Yes
The text was updated successfully, but these errors were encountered: