Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve home page template, fix Sort dropdown menu flash #23856

Merged
merged 2 commits into from
Apr 1, 2023
Merged

Improve home page template, fix Sort dropdown menu flash #23856

merged 2 commits into from
Apr 1, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Apr 1, 2023 •
edited
Loading

  1. Follow Make first section on home page full width #23854
    Major changes:
    1. The old <div class="ui"><div class="six wide column ..."> </div></div> doesn't have affect any more
      • So clean them, and remove other unnecessary elements/styles.
    2. Add padding for narrow view.

Before

image

After:

image

  1. Fix the Sort menu flash regression
    Fix Sort dropdown flashes when loading issue/pr list #23857

@wxiaoguang wxiaoguang mentioned this pull request Apr 1, 2023
Merged
@techknowlogick techknowlogick added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Apr 1, 2023
@techknowlogick techknowlogick added this to the 1.20.0 milestone Apr 1, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2023 •
edited
Loading

Codecov Report

Merging #23856 (3541518) into main (f521e88) will decrease coverage by 0.13%.
The diff coverage is 28.82%.

❗ Current head 3541518 differs from pull request most recent head 1286981. Consider uploading reports for the commit 1286981 to get more accurate results

@@            Coverage Diff             @@
##             main   #23856      +/-   ##
==========================================
- Coverage   47.14%   47.01%   -0.13%     
==========================================
  Files        1149     1158       +9     
  Lines      151446   153187    +1741     
==========================================
+ Hits        71397    72028     +631     
- Misses      71611    72665    +1054     
- Partials     8438     8494      +56
Impacted Files Coverage Δ
cmd/dump.go 0.66% <0.00%> (-0.01%) ⬇️
cmd/mailer.go 0.00% <0.00%> (ø)
cmd/manager.go 0.00% <0.00%> (ø)
cmd/manager_logging.go 0.00% <0.00%> (ø)
cmd/migrate_storage.go 5.76% <0.00%> (-0.12%) ⬇️
cmd/restore_repo.go 0.00% <0.00%> (ø)
cmd/web.go 0.00% <0.00%> (ø)
models/actions/run.go 1.63% <0.00%> (-0.10%) ⬇️
models/actions/runner.go 1.44% <ø> (ø)
models/packages/package.go 45.45% <0.00%> (-1.13%) ⬇️
... and 66 more

... and 72 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 1, 2023
@wxiaoguang wxiaoguang mentioned this pull request Apr 1, 2023
Closed
@wxiaoguang wxiaoguang changed the title Improve home page template Improve home page template, fix Sort dropdown menu flash Apr 1, 2023
@silverwind
Copy link
Member

Fix for #23857 confirmed.

@lunny lunny merged commit e216585 into go-gitea:main Apr 1, 2023
@wxiaoguang wxiaoguang deleted the improve-home branch April 1, 2023 06:12
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 3, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
a6741d8 
* upstream/main:
  [skip ci] Updated translations via Crowdin
  Update JS deps (go-gitea#23853)
  Added close/open button to details page of milestone (go-gitea#23877)
  Check `IsActionsToken` for LFS authentication (go-gitea#23841)
  Prefill input values in oauth settings as intended (go-gitea#23829)
  Display image size for multiarch container images (go-gitea#23821)
  Use clippie module to copy to clipboard (go-gitea#23801)
  Remove assertion debug code for show/hide refactoring (go-gitea#23576)
  [skip ci] Updated translations via Crowdin
  Remove jQuery ready usage (go-gitea#23858)
  Fix JS error when changing PR's target branch (go-gitea#23862)
  Improve action log display with control chars (go-gitea#23820)
  Fix review conversation reply (go-gitea#23846)
  Improve home page template, fix Sort dropdown menu flash (go-gitea#23856)
  Make first section on home page full width (go-gitea#23854)
  [skip ci] Updated translations via Crowdin
  Fix incorrect CORS failure detection logic (go-gitea#23844)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

Sort dropdown flashes when loading issue/pr list
6 participants
@wxiaoguang @codecov-commenter @silverwind @lunny @techknowlogick @GiteaBot