Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: update scripts to mirror libs-base setup #165

Merged
merged 2 commits into from
Jan 6, 2023
Merged

Conversation

triplef
Copy link
Member

@triplef triplef commented Jan 6, 2023

As suggested by Fred in gnustep/libs-base#285 (comment).

I basically took the updated libs-base scripts, removed the Windows section (GUI not supported yet), and added libs-base in dependencies.sh.

I also added the option for manual runs to use a different libs-base branch for testing.

Overall this mainly adds building GUI with libobjc2. I was wondering though, is anyone using the gnustep-1.9 runtime or could we remove this?

This is required by some tests, but currenetly disabled because some of these tests are failing.
@triplef
Copy link
Member Author

triplef commented Jan 6, 2023

I also tried re-adding libs-back (with option to use different branch for manual runs), which seems to be required by some of the tests. This was previously part of the CI setup but was removed by @gcasa in b98a309 as part of #114, presumable because some tests started failing with that PR.

For now I just commented out building libs-back, but if someone can fix the tests we can then re-enable it (independent of this PR).

These are the tests that are currently failing with lib-back (full test logs can be downloaded from the CI run):

gui/NSNibLoading/basic.m:
Failed test:     basic.m:52 ... .gorm file was loaded properly using loadNibNamed:owner:topLevelObjects:
Failed test:     basic.m:58 ... .xib file was loaded properly using loadNibNamed:owner:topLevelObjects:
Failed test:     basic.m:64 ... .nib file was loaded properly using loadNibNamed:owner:topLevelObjects:

gui/NSPopUpButton/defaultSelection.m:
Failed set:        defaultSelection.m:15 ... problem in NSPopupButton GNUstep defaultSelection.

gui/NSSavePanel/setDelegate_reload.m:
Failed set:        setDelegate_reload.m:49 ... problem in NSSavePanel GNUstep setDelegate.

gui/NSView/NSView_autoresize_and_rounding.m:
Failed set:        NSView_autoresize_and_rounding.m:59 ... problem in NSView GNUstep autoresize_and_rounding.

gui/NSView/NSView_bounds_scale.m:
Failed set:        NSView_bounds_scale.m:97 ... problem in NSView GNUstep bounds_scale.

gui/NSView/NSView_convertRect.m:
Failed set:        NSView_convertRect.m:100 ... problem in NSView GNUstep converRect.

gui/NSView/NSView_frame_bounds.m:
Failed set:        NSView_frame_bounds.m:57 ... problem in NSView GNUstep frame_bounds.

gui/NSView/NSView_frame_rotation.m:
Failed set:        NSView_frame_rotation.m:21 ... problem in NSView GNUstep frame_rotation.

gui/NSView/scrollRectToVisible.m:
Failed set:        scrollRectToVisible.m:33 ... problem in NSView GNUstep scrollRectToVisible.

@triplef triplef marked this pull request as ready for review January 6, 2023 17:47
@fredkiefer
Copy link
Member

Thank you! Looks great. I do an in detail review later on but as the three environments seem to work I don't expect to find any issues.

@fredkiefer fredkiefer merged commit e573b5c into master Jan 6, 2023
@fredkiefer fredkiefer deleted the ci-improvements branch January 6, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants