Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: various improvements #285

Merged
merged 1 commit into from
Jan 6, 2023
Merged

CI: various improvements #285

merged 1 commit into from
Jan 6, 2023

Conversation

triplef
Copy link
Member

@triplef triplef commented Jan 4, 2023

Various changes to modernize the CI and making it more reliable, mainly by using pre-built dependencies for the Windows MSVC targets instead of always building them ourselves (too much can go wrong in terms of servers being down etc.).

  • update GitHub actions (fixes Node.js 12 deprecation warnings)
  • separate Linux and Windows jobs
  • Windows MSVC: use dependencies from pre-built release instead of building dependencies on every run (with option to build dependencies when using manual "Run Workflow", example run here)
  • Windows MSVC: set GitHub token when building dependencies to prevent GitHub rate limit errors
  • remove installation of libkqueue-dev package (not used by libdispatch)
  • update dependencies from libobjc-9-dev to libobjc-10-dev
  • add -q flag to git clone to prevent progress logs from spamming logs

This is in a large part based on the changes from #199.

@triplef triplef force-pushed the ci-improvements branch 9 times, most recently from 6039854 to bc49f18 Compare January 4, 2023 02:36
@triplef triplef marked this pull request as ready for review January 4, 2023 03:20
@triplef triplef requested a review from rfm as a code owner January 4, 2023 03:20
@triplef
Copy link
Member Author

triplef commented Jan 4, 2023

@rfm I was wondering: would it be helpful to add another option for manual runs to be able to specify a tools-make branch? This would allow running builds and tests with changes to Make before merging them.

@rfm
Copy link
Contributor

rfm commented Jan 5, 2023

Yes, that makes sense to me.

- update GitHub actions (fixes Node.js 12 deprecation warnings)
- separate Linux and Windows jobs
- add option to specify tools-make branch for manual run
- Windows MSVC: use dependencies from pre-built release (with option to build dependencies via manual run)
- Windows MSVC: set GitHub token when building dependencies to prevent GitHub rate limit errors
- remove installation of libkqueue-dev package (not used by libdispatch)
- update dependencies from libobjc-9-dev to libobjc-10-dev
- add -q flag to git clone to prevent progress logs from spamming logs
@triplef
Copy link
Member Author

triplef commented Jan 5, 2023

@rfm I’ve added that option:

Bildschirm­foto 2023-01-05 um 09 16 26

For testing, here’s an example run using the "storyboard_support" branch of tools-make:
https://github.com/gnustep/libs-base/actions/runs/3848017672

@fredkiefer
Copy link
Member

Looks good to me. Frederik, do you have time to help me update the CI for GNUstep gui based on the code here?

@triplef
Copy link
Member Author

triplef commented Jan 6, 2023

@fredkiefer good idea, here you go: gnustep/libs-gui#165.

@triplef triplef merged commit e13195b into master Jan 6, 2023
@rfm
Copy link
Contributor

rfm commented Jan 7, 2023

Thanks

@triplef triplef deleted the ci-improvements branch June 3, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants