Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some minor improvements #76

Merged
merged 7 commits into from
Feb 18, 2021
Merged

Add some minor improvements #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
99d2df1
Remove .env file
mariano-aguero Feb 17, 2021
1e7aed0
Add .env to gitignore
mariano-aguero Feb 17, 2021
cfc078c
Add husky and lint-staged
mariano-aguero Feb 17, 2021
5b3b790
Update readme
mariano-aguero Feb 17, 2021
d7d166e
Remove .env file
mariano-aguero Feb 17, 2021
d602ebf
Add more env vars
mariano-aguero Feb 18, 2021
61a1de7
(fix) name case
gabitoesmiapodo Feb 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .env
View file
Open in desktop

This file was deleted.

8 changes: 8 additions & 0 deletions .env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
REACT_APP_CHAIN_ID=4
REACT_APP_NETWORK_URL="PUT_YOUR_INFURA_URL"
REACT_APP_ADDITIONAL_SERVICES_API_URL="PUT_YOUR_API_URL"
REACT_APP_ADDITIONAL_SERVICES_API_URL_PROD="PUT_YOUR_API_URL_FOR_PRODUCTION"
REACT_APP_GOOGLE_ANALYTICS_ID="PUT_YOUR_GOOGLE_ANALYTICS_ID"
REACT_APP_GIT_COMMIT_HASH="PUT_YOUR_LAST_COMMIT_HASH"
REACT_APP_FORTMATIC_KEY="PUT_YOUR_FORTMATIC_KEY"
REACT_APP_PORTIS_ID="PUT_YOUR_PORTIS_ID"
4 changes: 3 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,6 @@ package-lock.json

cypress/videos
cypress/screenshots
cypress/fixtures/example.json
cypress/fixtures/example.json

.env
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ yarn

### Configure Environment

Copy `.env` to `.env.local` and change the appropriate variables.
Copy `.env.example` to `.env` and change the appropriate variables.

### Run

Expand Down
19 changes: 16 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@uniswap/interface",
"description": "Uniswap Interface",
"name": "gnosis-auction",
"description": "Gnosis Auction",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To take into account, I modified the name and description

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, "Easy IDO auction" is a better name, any thoughts about it @josojo ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like gnosis-auction better.

"homepage": ".",
"private": true,
"devDependencies": {
Expand Down Expand Up @@ -52,12 +52,14 @@
"eslint-plugin-prettier": "^3.1.4",
"eslint-plugin-react": "^7.19.0",
"eslint-plugin-react-hooks": "^4.0.0",
"husky": "^4.3.6",
"i18next": "^15.0.9",
"i18next-browser-languagedetector": "^3.0.1",
"i18next-xhr-backend": "^2.0.1",
"isexe": "^2.0.0",
"jazzicon": "^1.5.0",
"levenary": "^1.1.1",
"lint-staged": "^10.5.3",
"lodash.flatmap": "^4.5.0",
"modali": "^1.2.0",
"polished": "^3.3.2",
Expand Down Expand Up @@ -93,7 +95,7 @@
"eject": "react-scripts eject",
"lint": "eslint 'src/**/*.{js,jsx,ts,tsx}' --fix",
"lint:fix": "eslint 'src/**/*.{js,jsx,ts,tsx}' --fix",
"prettier:ts": "prettier --write './**/*.{js,jsx,ts,tsx}'",
"prettier:fix": "prettier --write './src/**/*.{js,jsx,ts,tsx}'",
"cy:run": "cypress run",
"serve:build": "serve -s build -l 3000",
"integration-test": "yarn build && start-server-and-test 'yarn run serve:build' http://localhost:3000 cy:run"
Expand All @@ -117,5 +119,16 @@
"dependencies": {
"inter-ui": "^3.15.0",
"react-table": "^7.6.3"
},
"lint-staged": {
"src/**/*.{js,jsx,ts,tsx}": [
"yarn run lint:fix",
"yarn run prettier:fix"
]
},
"husky": {
"hooks": {
"pre-commit": "lint-staged"
}
}
}
Loading