Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some minor improvements #76

Merged
merged 7 commits into from
Feb 18, 2021
Merged

Add some minor improvements #76

merged 7 commits into from
Feb 18, 2021

Conversation

mariano-aguero
Copy link
Contributor

  • Remove env file (should not be commited)
  • Added .env.example
  • Added husky and lint-staged
  • Modified some chore files

@mariano-aguero mariano-aguero self-assigned this Feb 17, 2021
mariano-aguero
mariano-aguero commented Feb 17, 2021
View reviewed changes
package.json
"name": "@uniswap/interface",
"description": "Uniswap Interface",
"name": "Gnosis-Auction",
"description": "Gnosis Auction",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To take into account, I modified the name and description

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, "Easy IDO auction" is a better name, any thoughts about it @josojo ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like gnosis-auction better.

@github-actions
Copy link

  • 🔭 IDO UI: Easy IDO auction

gabitoesmiapodo
gabitoesmiapodo approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@gabitoesmiapodo gabitoesmiapodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

giphy

@gabitoesmiapodo gabitoesmiapodo merged commit 879aa5d into develop Feb 18, 2021
@gabitoesmiapodo gabitoesmiapodo deleted the add-some-improvements branch February 18, 2021 12:51
gabitoesmiapodo added a commit that referenced this pull request Feb 18, 2021
@gabitoesmiapodo
Merge branch 'develop' into feature/#62-#74
df322cc 
* develop:
  Add some minor improvements (#76)

# Conflicts:
#	package.json
@josojo
Copy link
Contributor

josojo commented Feb 19, 2021

Actually, this PR broke the auto deployment. It needs the .env.

@marcovc could you look into either reinserting the .env file or supply a configuration to the github workflow for the auto-deployment?

@marcovc
Copy link

marcovc commented Feb 19, 2021

Just checking: is it me you wanted to tag here? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabitoesmiapodo gabitoesmiapodo gabitoesmiapodo approved these changes

@josojo josojo josojo approved these changes

@0xslipk 0xslipk Awaiting requested review from 0xslipk

Assignees

@mariano-aguero mariano-aguero

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mariano-aguero @josojo @marcovc @gabitoesmiapodo