Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add improvements to the chart #153

Merged
merged 3 commits into from
Mar 11, 2021
Merged

Add improvements to the chart #153

merged 3 commits into from
Mar 11, 2021

Conversation

mariano-aguero
Copy link
Contributor

Closes #38
Closes #67
Now look like this ...

Screenshot_20210309_204826
Screenshot_20210309_204842
Screenshot_20210309_204731
Screenshot_20210309_204751
Screenshot_20210309_204812

@mariano-aguero mariano-aguero self-assigned this Mar 10, 2021
@github-actions
Copy link

  • 🔭 IDO UI: Easy IDO auction

@josojo
Copy link
Contributor

josojo commented Mar 10, 2021

I tried to open the PR, but got the following error:
image
No clue what it is. it does not appear on coolest-design-ever

@josojo
Copy link
Contributor

josojo commented Mar 10, 2021

I think the legend is pretty cool! Nice solution

@josojo
Copy link
Contributor

josojo commented Mar 10, 2021

Nice, It looks soo much better! cool

image

Maybe it would look nicer if we switch from a 3 grid pattern in the graph(three columns) to a 5 grid pattern and set the graph in such a way that 3 of the 5 columns are occupied - instead of 1 column from 3.
But this is really just an idea. Not sure whether it really would look better.

@mariano-aguero
Copy link
Contributor Author

Nice, It looks soo much better! cool

image

Maybe it would look nicer if we switch from a 3 grid pattern in the graph(three columns) to a 5 grid pattern and set the graph in such a way that 3 of the 5 columns are occupied - instead of 1 column from 3.
But this is really just an idea. Not sure whether it really would look better.

Mmm let me try

@mariano-aguero
Copy link
Contributor Author

@josojo mm what about like this ?

Screenshot_20210311_003139

josojo
josojo approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@josojo josojo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, like it much better. Great improvement.

image
Maybe we need to introduce a min-height for the graph ( screenshot taken on auctionId=2&chainId=4

@gabitoesmiapodo gabitoesmiapodo merged commit 733adea into coolest-design-ever Mar 11, 2021
@gabitoesmiapodo gabitoesmiapodo deleted the improvement-chart branch March 11, 2021 11:59
gabitoesmiapodo added a commit that referenced this pull request Mar 11, 2021
@mariano-aguero @gabitoesmiapodo
@josojo @0xslipk
(Feature) New design (#107)
92e8e18 
* (Feature) New general layout (#100)

* (add) sanitize.css

* (fix) linting and general setup

* (add) common components

* (add) footer, header

* (fix) icon color

* (add) favicon

* (Add) header user not connected styles

* (fix) footer styles

* (add) header dropdown

* (add) user address

* (add) user dropdown changes

* (add) dropdown styles

* (add) connect modal

* (add) transactions modal

* (add) theme switch

* (remove) unused component

* (hide) theme toggle

* Fix some linter errors

* Update linter config

* Update yarn.lock

* Add engine

* Add test to clear cache

* Revert last commit

* Fix lint problems

* Fix more lint problems

* Fix typo

* Add getWalletName and disconnect

Co-authored-by: Mariano Aguero <mariano.aguero@gmail.com>

* Auction page should load, even if web3 wallet is not yet connected. (#108)

* Add support to use the application offline

* Remove unused vars

* tiny corrections

Co-authored-by: josojo <josojo@hotmail.de>

* Add improvements for typings (#111)

* Improve typings

* Add env CI: false to test deploy

* Add ignore comments for the moment

* Fix small typo (#112)

* fixes nasty error: tx arguments not correct (#117)

* Allow the api to fetch data, even when account is not loaded (#116)

* Fix import

* (Feature) Auction Details (#115)

* (add) sanitize.css

* (fix) linting and general setup

* (add) common components

* (add) footer, header

* (fix) icon color

* (add) favicon

* (Add) header user not connected styles

* (fix) footer styles

* (add) header dropdown

* (add) user address

* (add) user dropdown changes

* (add) dropdown styles

* (add) connect modal

* (add) transactions modal

* (add) theme switch

* (remove) unused component

* (remove) more unused components

* (hide) theme toggle

* Fix some linter errors

* Update linter config

* Update yarn.lock

* Add engine

* (fix) linting

* (remove) unused component

* (add) title, subtitle, copy button

* (add) auction details values

* (add) tooltip

* (add) external link button

* (remove) unused dependency

* (add) token icons

* (add) separation

* (add) base timer

* (refactor) timer code

* (add) text format

* (add) timer and grid styles

* (fix) auction progress

* (add) orders table

* (add) status icons

* (fix) crash

* (add) missing auction state

* (fix) linting

* (fix) make the auctions page less messy

* (fix) several layout issues

* (add) spinner

* (add) buttons

* (add) token text

* (add) amount input

* (add) price input

* (add) some checking

* (add) spinner for chart

* (add) approval text

* (fix) fuckup

* (fix) validations

* (fix) validations and folder placement

* (add) error display

* (add) better errors

* Fix modal warning

Co-authored-by: Mariano Aguero <mariano.aguero@gmail.com>

* Fix small problems in the console (#121)

* Fix problem with auction info card

* Fix division by zero (#123)

* Add continue when a buyAmount is zero

* Add console error

* [issues-98] Pulling in the tokenLogo (#127)

* pull logos from uniswap token list

* fetch all tokens at the same time

* Add new endpoint for auctions (#129)

* Add endpoint to fetch auction details

* Add hook to fetch auction details

* Fix bad use of useMemo

* Refactoring

* Update hook to use the new endpoint for auction details

* Apply update to use auctionStartDate and a setInterval instead of setTimeout

* (feature) Landing Page (#138)

* (add) sanitize.css

* (fix) linting and general setup

* (add) common components

* (add) footer, header

* (fix) icon color

* (add) favicon

* (Add) header user not connected styles

* (fix) footer styles

* (add) header dropdown

* (add) user address

* (add) user dropdown changes

* (add) dropdown styles

* (add) connect modal

* (add) transactions modal

* (add) theme switch

* (remove) unused component

* (remove) more unused components

* (hide) theme toggle

* Fix some linter errors

* Update linter config

* Update yarn.lock

* Add engine

* (fix) linting

* (remove) unused component

* (add) title, subtitle, copy button

* (add) auction details values

* (add) tooltip

* (add) external link button

* (remove) unused dependency

* (add) token icons

* (add) separation

* (add) base timer

* (refactor) timer code

* (add) text format

* (add) timer and grid styles

* (fix) auction progress

* (add) orders table

* (add) status icons

* (fix) crash

* (add) missing auction state

* (fix) linting

* (fix) make the auctions page less messy

* (fix) several layout issues

* (add) spinner

* (add) buttons

* (add) token text

* (add) amount input

* (add) price input

* (add) some checking

* (add) spinner for chart

* (add) approval text

* (fix) fuckup

* (fix) validations

* (fix) validations and folder placement

* (add) error display

* (add) better errors

* (add) some routes and placeholder sections

* (update) gitignore

* (fix) gitignore

* (add) featured auctions loading spinner

* (add) landing page contents

* (add) landing page contents

* (add) featured auctions card styles

* (update) yarn.lock

* (add) featured actions progress bar

* (fix) auction progress

* (fix) scroll

Co-authored-by: Mariano Aguero <mariano.aguero@gmail.com>

* Solution to several issues (#139)

* Update lock file

* Add check for undefined

* Add loading and claiming state

* Add symbol tokens

* Add new property

* Fix perfomance issue

* Add loading validation

* Add improvement to hook using auction details endpoint

* Revert config redux

* Fix validations

* Fix decimals (#145)

* Allow to fetch all highlighted auctions from all networks (#146)

* (Feature) Claiming (#149)

* (add) claiming section styles

* (fix) make paths windows compatible

* (fix) Invalid network error (#154)

* fix invalid netwrok error

* (remove) console statement

Co-authored-by: Gabriel Rodriguez Alsina <gabriel.rodriguez@altoros.com>

* Add improvement for order cancellation (#155)

* Add improvements to the chart (#153)

* Add improvements to the chart

* Add proper validation for tokens

* Remove unused component, add more grids

* (Feature) Several fixes (#156)

* (add) text gradient

* (add) token logo

* (add) token placeholder for missing token's images

* (fix) logo font

* (add) Auction's network to featured auctions cards.

* (fix) token symbol font size

* (add) network name to auction details

* (remove) text

* (add) better text description

Co-authored-by: Gabriel Rodríguez Alsina <gabitoesmiapodo@users.noreply.github.com>
Co-authored-by: josojo <josojo@hotmail.de>
Co-authored-by: Jose A. Ramirez C <jarcodallo@gmail.com>
Co-authored-by: Gabriel Rodriguez Alsina <gabriel.rodriguez@altoros.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabitoesmiapodo gabitoesmiapodo gabitoesmiapodo approved these changes

@josojo josojo josojo approved these changes

@0xslipk 0xslipk Awaiting requested review from 0xslipk

Assignees

@mariano-aguero mariano-aguero

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mariano-aguero @josojo @gabitoesmiapodo