Add improvements for typings #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
josojo
approved these changes
Feb 26, 2021
.github/workflows/deploy.yml
Outdated
| @@ -9,7 +9,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| env: | |||
| REPO_NAME_SLUG: idoux | |||
|
|
|||
| CI: false | |||
There was a problem hiding this comment.
I would prefer to not do this change, but rather change the linter configuration that it does not complain about todo's
There was a problem hiding this comment.
Is ok for me, I removed and changed the linter configuration
gabitoesmiapodo
added a commit
that referenced
this pull request
Mar 11, 2021
* (Feature) New general layout (#100) * (add) sanitize.css * (fix) linting and general setup * (add) common components * (add) footer, header * (fix) icon color * (add) favicon * (Add) header user not connected styles * (fix) footer styles * (add) header dropdown * (add) user address * (add) user dropdown changes * (add) dropdown styles * (add) connect modal * (add) transactions modal * (add) theme switch * (remove) unused component * (hide) theme toggle * Fix some linter errors * Update linter config * Update yarn.lock * Add engine * Add test to clear cache * Revert last commit * Fix lint problems * Fix more lint problems * Fix typo * Add getWalletName and disconnect Co-authored-by: Mariano Aguero <mariano.aguero@gmail.com> * Auction page should load, even if web3 wallet is not yet connected. (#108) * Add support to use the application offline * Remove unused vars * tiny corrections Co-authored-by: josojo <josojo@hotmail.de> * Add improvements for typings (#111) * Improve typings * Add env CI: false to test deploy * Add ignore comments for the moment * Fix small typo (#112) * fixes nasty error: tx arguments not correct (#117) * Allow the api to fetch data, even when account is not loaded (#116) * Fix import * (Feature) Auction Details (#115) * (add) sanitize.css * (fix) linting and general setup * (add) common components * (add) footer, header * (fix) icon color * (add) favicon * (Add) header user not connected styles * (fix) footer styles * (add) header dropdown * (add) user address * (add) user dropdown changes * (add) dropdown styles * (add) connect modal * (add) transactions modal * (add) theme switch * (remove) unused component * (remove) more unused components * (hide) theme toggle * Fix some linter errors * Update linter config * Update yarn.lock * Add engine * (fix) linting * (remove) unused component * (add) title, subtitle, copy button * (add) auction details values * (add) tooltip * (add) external link button * (remove) unused dependency * (add) token icons * (add) separation * (add) base timer * (refactor) timer code * (add) text format * (add) timer and grid styles * (fix) auction progress * (add) orders table * (add) status icons * (fix) crash * (add) missing auction state * (fix) linting * (fix) make the auctions page less messy * (fix) several layout issues * (add) spinner * (add) buttons * (add) token text * (add) amount input * (add) price input * (add) some checking * (add) spinner for chart * (add) approval text * (fix) fuckup * (fix) validations * (fix) validations and folder placement * (add) error display * (add) better errors * Fix modal warning Co-authored-by: Mariano Aguero <mariano.aguero@gmail.com> * Fix small problems in the console (#121) * Fix problem with auction info card * Fix division by zero (#123) * Add continue when a buyAmount is zero * Add console error * [issues-98] Pulling in the tokenLogo (#127) * pull logos from uniswap token list * fetch all tokens at the same time * Add new endpoint for auctions (#129) * Add endpoint to fetch auction details * Add hook to fetch auction details * Fix bad use of useMemo * Refactoring * Update hook to use the new endpoint for auction details * Apply update to use auctionStartDate and a setInterval instead of setTimeout * (feature) Landing Page (#138) * (add) sanitize.css * (fix) linting and general setup * (add) common components * (add) footer, header * (fix) icon color * (add) favicon * (Add) header user not connected styles * (fix) footer styles * (add) header dropdown * (add) user address * (add) user dropdown changes * (add) dropdown styles * (add) connect modal * (add) transactions modal * (add) theme switch * (remove) unused component * (remove) more unused components * (hide) theme toggle * Fix some linter errors * Update linter config * Update yarn.lock * Add engine * (fix) linting * (remove) unused component * (add) title, subtitle, copy button * (add) auction details values * (add) tooltip * (add) external link button * (remove) unused dependency * (add) token icons * (add) separation * (add) base timer * (refactor) timer code * (add) text format * (add) timer and grid styles * (fix) auction progress * (add) orders table * (add) status icons * (fix) crash * (add) missing auction state * (fix) linting * (fix) make the auctions page less messy * (fix) several layout issues * (add) spinner * (add) buttons * (add) token text * (add) amount input * (add) price input * (add) some checking * (add) spinner for chart * (add) approval text * (fix) fuckup * (fix) validations * (fix) validations and folder placement * (add) error display * (add) better errors * (add) some routes and placeholder sections * (update) gitignore * (fix) gitignore * (add) featured auctions loading spinner * (add) landing page contents * (add) landing page contents * (add) featured auctions card styles * (update) yarn.lock * (add) featured actions progress bar * (fix) auction progress * (fix) scroll Co-authored-by: Mariano Aguero <mariano.aguero@gmail.com> * Solution to several issues (#139) * Update lock file * Add check for undefined * Add loading and claiming state * Add symbol tokens * Add new property * Fix perfomance issue * Add loading validation * Add improvement to hook using auction details endpoint * Revert config redux * Fix validations * Fix decimals (#145) * Allow to fetch all highlighted auctions from all networks (#146) * (Feature) Claiming (#149) * (add) claiming section styles * (fix) make paths windows compatible * (fix) Invalid network error (#154) * fix invalid netwrok error * (remove) console statement Co-authored-by: Gabriel Rodriguez Alsina <gabriel.rodriguez@altoros.com> * Add improvement for order cancellation (#155) * Add improvements to the chart (#153) * Add improvements to the chart * Add proper validation for tokens * Remove unused component, add more grids * (Feature) Several fixes (#156) * (add) text gradient * (add) token logo * (add) token placeholder for missing token's images * (fix) logo font * (add) Auction's network to featured auctions cards. * (fix) token symbol font size * (add) network name to auction details * (remove) text * (add) better text description Co-authored-by: Gabriel Rodríguez Alsina <gabitoesmiapodo@users.noreply.github.com> Co-authored-by: josojo <josojo@hotmail.de> Co-authored-by: Jose A. Ramirez C <jarcodallo@gmail.com> Co-authored-by: Gabriel Rodriguez Alsina <gabriel.rodriguez@altoros.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like a lot of modifications, but it is just a small refactor for the use of "Maybe". I also added the typing files in the configuration because typescript wasn't taking them in strict mode.