Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove database and host components. #576

Merged
merged 3 commits into from
Jul 30, 2021
Merged

Remove database and host components. #576

merged 3 commits into from
Jul 30, 2021

Conversation

bdice
Copy link
Member

@bdice bdice commented Jul 23, 2021

Description

This PR follows #575.

  • Remove database and host components.
  • Update docs/setup files.

Motivation and Context

Part of signac 2.0 API cleanup.

Types of Changes

  • Documentation update
  • Bug fix
  • New feature
  • Breaking change1

1The change breaks (or has the potential to break) existing functionality.

Checklist:

If necessary:

  • I have updated the API documentation as part of the package doc-strings.
  • I have created a separate pull request to update the framework documentation on signac-docs and linked it here.
  • I have updated the changelog and added all related issue and pull request numbers for future reference (if applicable). See example below.

@bdice bdice requested review from a team as code owners July 23, 2021 16:37
@bdice bdice requested review from b-butler and Tobias-Dwyer and removed request for a team July 23, 2021 16:37
@bdice bdice marked this pull request as draft July 23, 2021 16:37
@bdice bdice added this to the v2.0.0 milestone Jul 23, 2021
@bdice bdice self-assigned this Jul 23, 2021
@bdice bdice changed the base branch from master to remove/mpipool-filesystems July 23, 2021 16:38
@mikemhenry
Copy link
Collaborator

tasty
+13 −1,067

@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #576 (8c25029) into next (e8e949f) will increase coverage by 1.93%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #576      +/-   ##
==========================================
+ Coverage   80.48%   82.42%   +1.93%     
==========================================
  Files          59       54       -5     
  Lines        6319     5850     -469     
  Branches     1179     1097      -82     
==========================================
- Hits         5086     4822     -264     
+ Misses        945      785     -160     
+ Partials      288      243      -45     
Impacted Files Coverage Δ
signac/contrib/utility.py 47.79% <ø> (-4.06%) ⬇️
signac/core/utility.py 91.30% <ø> (+19.08%) ⬆️
signac/__main__.py 74.72% <50.00%> (+3.32%) ⬆️
signac/__init__.py 100.00% <100.00%> (ø)
signac/common/validate.py 39.13% <0.00%> (-34.79%) ⬇️
signac/common/config.py 67.28% <0.00%> (-14.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8e949f...8c25029. Read the comment docs.

@bdice bdice mentioned this pull request Jul 26, 2021
14 tasks
@bdice bdice added the blocked Dependent on something else label Jul 26, 2021
Base automatically changed from remove/mpipool-filesystems to next July 28, 2021 20:48
@bdice bdice removed the blocked Dependent on something else label Jul 28, 2021
@bdice bdice force-pushed the remove/db-host branch 2 times, most recently from 4a17256 to c524915 Compare July 28, 2021 20:56
@bdice bdice marked this pull request as ready for review July 28, 2021 21:02
@bdice bdice closed this Jul 28, 2021
@bdice bdice reopened this Jul 28, 2021
@bdice bdice requested review from vyasr and tommy-waltmann July 28, 2021 21:10
@bdice
Copy link
Member Author

bdice commented Jul 28, 2021

@vyasr @tommy-waltmann I assigned you as reviewers because Brandon (the suggested committer) is out this week and you two were some of the last developers to touch these files. This PR is a dependency of #580, which I will re-work once this PR is merged.

@bdice bdice merged commit f3448e4 into next Jul 30, 2021
@bdice bdice deleted the remove/db-host branch July 30, 2021 19:07
vyasr pushed a commit that referenced this pull request Nov 9, 2021
* Remove database and host components.

* Update docs/setup files.

* Remove utility function.
bdice added a commit that referenced this pull request Dec 5, 2021
* Remove database and host components.

* Update docs/setup files.

* Remove utility function.
vyasr pushed a commit that referenced this pull request Dec 25, 2021
* Remove database and host components.

* Update docs/setup files.

* Remove utility function.
vyasr pushed a commit that referenced this pull request Jan 4, 2022
* Remove database and host components.

* Update docs/setup files.

* Remove utility function.
vyasr pushed a commit that referenced this pull request Jan 27, 2022
* Remove database and host components.

* Update docs/setup files.

* Remove utility function.
vyasr pushed a commit that referenced this pull request Feb 4, 2022
* Remove database and host components.

* Update docs/setup files.

* Remove utility function.
vyasr pushed a commit that referenced this pull request Feb 21, 2022
* Remove database and host components.

* Update docs/setup files.

* Remove utility function.
vyasr pushed a commit that referenced this pull request Feb 21, 2022
* Remove database and host components.

* Update docs/setup files.

* Remove utility function.
vyasr pushed a commit that referenced this pull request Mar 14, 2022
* Remove database and host components.

* Update docs/setup files.

* Remove utility function.
vyasr pushed a commit that referenced this pull request Apr 19, 2022
* Remove database and host components.

* Update docs/setup files.

* Remove utility function.
vyasr pushed a commit that referenced this pull request Apr 21, 2022
* Remove database and host components.

* Update docs/setup files.

* Remove utility function.
vyasr pushed a commit that referenced this pull request May 2, 2022
* Remove database and host components.

* Update docs/setup files.

* Remove utility function.
bdice added a commit that referenced this pull request Jun 14, 2022
* Remove database and host components.

* Update docs/setup files.

* Remove utility function.
bdice added a commit that referenced this pull request Aug 1, 2022
* Remove database and host components.

* Update docs/setup files.

* Remove utility function.
bdice added a commit that referenced this pull request Oct 7, 2022
* Remove database and host components.

* Update docs/setup files.

* Remove utility function.
bdice added a commit that referenced this pull request Oct 27, 2022
* Remove database and host components.

* Update docs/setup files.

* Remove utility function.
vyasr pushed a commit that referenced this pull request Oct 30, 2022
* Remove database and host components.

* Update docs/setup files.

* Remove utility function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants