feat(Flows): Adds OpenAPI type generation and export for Flows service#548
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #548 +/- ##
==========================================
- Coverage 94.92% 94.92% -0.01%
==========================================
Files 75 75
Lines 1380 1379 -1
Branches 228 228
==========================================
- Hits 1310 1309 -1
Misses 69 69
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jbottigliero
force-pushed
the
feat-flows-types
branch
from
85a942d to
4bd59da
Compare
jakeglobus
approved these changes
Jun 18, 2025
jakeglobus
left a comment
jakeglobus
left a comment
Contributor
There was a problem hiding this comment.
This looks good given that the spec gets updated to be valid...maybe even if it doesn't?
Member
Author
👍 – I expect that PR to get merged in just a few too! |
jbottigliero
pushed a commit
that referenced
this pull request
Sep 3, 2025
🤖 I have created a release *beep* *boop* --- ## [6.0.0](v5.8.0...v6.0.0) (2025-09-02) ### ⚠ BREAKING CHANGES * **Timers:** Timer renamed to Timer*s*, Moves `timer.create` export to `timers.timer.create` to better reflect API. ([#533](#533)) * Drops support for Node.js 18 ([#520](#520)) ### Features * Allows passing `manager` as ServiceMethodOptions ([#597](#597)) ([d99703d](d99703d)) * **Authorization:** adds experimental `PopupTransport` for AuthorizationManager ([#461](#461)) ([94d87fb](94d87fb)) * **Compute:** Adds `endpoint.update` and `remove` methods ([#524](#524)) ([6ee61ff](6ee61ff)) * Drops support for Node.js 18 ([#520](#520)) ([ae67d68](ae67d68)) * **Flows:** add `runs.get` method for retrieving specific run details ([#534](#534)) ([64a28a2](64a28a2)) * **Flows:** Adds OpenAPI type generation and export for Flows service ([#548](#548)) ([6bdd0c4](6bdd0c4)) * **Flows:** use `OpenAPI` specs for Run method types ([#556](#556)) ([4dac4d3](4dac4d3)) * **Timer:** add Timer Jobs methods ([#531](#531)) ([392035b](392035b)) * **Transfer:** Adds support for roles operations. ([#537](#537)) ([1fc00e0](1fc00e0)) * **Typescript:** Use internal, OpenAPI-generated, types for Compute, GCS, Groups, and Timer. ([#447](#447)) ([7c98b08](7c98b08)) ### Bug Fixes * **Flows:** Ensure OpenAPI types are included as return types to service methods ([#564](#564)) ([9e19a8e](9e19a8e)) * **Transfer:** Updates `getDomainFromEndpoint` to ensure support for custom (sub)domains with dashes. ([#621](#621)) ([c10e24d](c10e24d)) * **Typescript, Flows:** Updates OpenAPI URL and regenerates types. ([#554](#554)) ([c960bad](c960bad)) * **Typescript:** Fix incorrect calls to `PaginatedResponse` and improve the generic. ([#550](#550)) ([294d9f4](294d9f4)) ### Code Refactoring * **Timers:** Timer renamed to Timer*s*, Moves `timer.create` export to `timers.timer.create` to better reflect API. ([#533](#533)) ([d8fc964](d8fc964)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
src/open-api/types/flows.tswas initially generated from a modified version of the Flow service's published OpenAPI spec to address missing$refvalues and more accurate types (globusonline/globus-flows#1353).The scheduled runner will technically be broken until those changes are incorporated and published, if this is merged.