Skip to content

feat(Authorization): adds experimental PopupTransport for AuthorizationManager#461

Merged
jbottigliero merged 4 commits into
mainfrom
feat-PopupTransport
Jun 13, 2025
Merged

feat(Authorization): adds experimental PopupTransport for AuthorizationManager#461
jbottigliero merged 4 commits into
mainfrom
feat-PopupTransport

Conversation

@jbottigliero

Copy link
Copy Markdown
Member

This pull request introduces a new transport for the AuthorizationManager – the PopTransport.

This transport is intended to facilitate using @globus/sdk as an authorization mechanism when a redirect is not possible (e.g. when inside of an <iframe>).

<MORE DOCUMENTATION TO FOLLOW>


Attached is an example of the usage in an experimental Storybook.

Screen.Cast.2025-03-20.at.9.06.41.AM.mp4

@jbottigliero jbottigliero force-pushed the feat-PopupTransport branch 2 times, most recently from 5f1f2df to 6041b32 Compare March 20, 2025 18:38
@codecov

codecov Bot commented Mar 20, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 38.63636% with 54 lines in your changes missing coverage. Please review.

Project coverage is 94.92%. Comparing base (1fc00e0) to head (ae24e25).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/core/authorization/PopupTransport.ts 10.34% 45 Missing and 7 partials ⚠️
src/core/authorization/AuthorizationManager.ts 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #461      +/-   ##
==========================================
- Coverage   98.77%   94.92%   -3.86%     
==========================================
  Files          74       75       +1     
  Lines        1310     1380      +70     
  Branches      211      228      +17     
==========================================
+ Hits         1294     1310      +16     
- Misses         15       62      +47     
- Partials        1        8       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jbottigliero jbottigliero force-pushed the feat-PopupTransport branch 2 times, most recently from e56761d to c4de20e Compare March 27, 2025 15:27
@jbottigliero jbottigliero marked this pull request as ready for review June 13, 2025 18:51
@jbottigliero jbottigliero force-pushed the feat-PopupTransport branch from c4de20e to ae24e25 Compare June 13, 2025 18:52
@jbottigliero jbottigliero changed the title wip:feat(Authorization): adds experimental PopupTransport for AuthorizationManager feat(Authorization): adds experimental PopupTransport for AuthorizationManager Jun 13, 2025
@jbottigliero jbottigliero merged commit 94d87fb into main Jun 13, 2025
8 of 10 checks passed
@jbottigliero jbottigliero deleted the feat-PopupTransport branch June 13, 2025 20:28
jbottigliero pushed a commit that referenced this pull request Sep 3, 2025
🤖 I have created a release *beep* *boop*
---


##
[6.0.0](v5.8.0...v6.0.0)
(2025-09-02)


### ⚠ BREAKING CHANGES

* **Timers:** Timer renamed to Timer*s*, Moves `timer.create` export to
`timers.timer.create` to better reflect API.
([#533](#533))
* Drops support for Node.js 18
([#520](#520))

### Features

* Allows passing `manager` as ServiceMethodOptions
([#597](#597))
([d99703d](d99703d))
* **Authorization:** adds experimental `PopupTransport` for
AuthorizationManager
([#461](#461))
([94d87fb](94d87fb))
* **Compute:** Adds `endpoint.update` and `remove` methods
([#524](#524))
([6ee61ff](6ee61ff))
* Drops support for Node.js 18
([#520](#520))
([ae67d68](ae67d68))
* **Flows:** add `runs.get` method for retrieving specific run details
([#534](#534))
([64a28a2](64a28a2))
* **Flows:** Adds OpenAPI type generation and export for Flows service
([#548](#548))
([6bdd0c4](6bdd0c4))
* **Flows:** use `OpenAPI` specs for Run method types
([#556](#556))
([4dac4d3](4dac4d3))
* **Timer:** add Timer Jobs methods
([#531](#531))
([392035b](392035b))
* **Transfer:** Adds support for roles operations.
([#537](#537))
([1fc00e0](1fc00e0))
* **Typescript:** Use internal, OpenAPI-generated, types for Compute,
GCS, Groups, and Timer.
([#447](#447))
([7c98b08](7c98b08))


### Bug Fixes

* **Flows:** Ensure OpenAPI types are included as return types to
service methods
([#564](#564))
([9e19a8e](9e19a8e))
* **Transfer:** Updates `getDomainFromEndpoint` to ensure support for
custom (sub)domains with dashes.
([#621](#621))
([c10e24d](c10e24d))
* **Typescript, Flows:** Updates OpenAPI URL and regenerates types.
([#554](#554))
([c960bad](c960bad))
* **Typescript:** Fix incorrect calls to `PaginatedResponse` and improve
the generic.
([#550](#550))
([294d9f4](294d9f4))


### Code Refactoring

* **Timers:** Timer renamed to Timer*s*, Moves `timer.create` export to
`timers.timer.create` to better reflect API.
([#533](#533))
([d8fc964](d8fc964))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant