fix(Typescript, Search): Improve the GFacet Search type #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #426 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 72 72
Lines 1254 1254
Branches 210 210
=======================================
Hits 1238 1238
Misses 15 15
Partials 1 1 ☔ View full report in Codecov by Sentry. |
jbottigliero
pushed a commit
that referenced
this pull request
Feb 6, 2025
🤖 I have created a release *beep* *boop* --- ## [5.5.0](v5.4.1...v5.5.0) (2025-02-06) ### Features * **Search:** Adds support for Search Index Roles CRUD methods. ([#425](#425)) ([1b40d08](1b40d08)) ### Bug Fixes * **Transfer, Typescript:** Adds TransferErrorDocument type and improves DirectoryListingError types. ([#420](#420)) ([aadfbdf](aadfbdf)) * **Typescript, Search:** Improve the GFacet Search type ([#426](#426)) ([1b245a5](1b245a5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like a more accurate representation of https://docs.globus.org/api/search/reference/post_query/#gfacet...
I was specifically encountering an issue with
sizenot being allowed (optional) when usingtype: "terms".