feat(Search): Add index roles CRUD#425
Conversation
jakeglobus
force-pushed
the
add-index-roles-crud
branch
from
bab9423 to
f5e8c7d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #425 +/- ##
==========================================
+ Coverage 98.71% 98.72% +0.01%
==========================================
Files 71 72 +1
Lines 1242 1254 +12
Branches 210 210
==========================================
+ Hits 1226 1238 +12
Misses 15 15
Partials 1 1 ☔ View full report in Codecov by Sentry. |
jbottigliero
left a comment
jbottigliero
left a comment
There was a problem hiding this comment.
Looks good, but just needs to be moved to a separate roles file and method names updated.
| * | ||
| * @see https://docs.globus.org/api/search/reference/role_list/ | ||
| */ | ||
| export const getRoles = function ( |
There was a problem hiding this comment.
To match the other services and resources, I think this should actually be search.index.roles(.getAll | .create | .remove)
https://globus.github.io/globus-sdk-javascript/modules/_globus_sdk.html#service-method-names
There was a problem hiding this comment.
Ah oops, I'll get that fixed up
There was a problem hiding this comment.
Okay, I think it's okay now. I'm not totally sure about the module export from search/index.ts though so please double check me there
There was a problem hiding this comment.
👍 - I just swapped the changes in search/index.js for: https://github.com/globus/globus-sdk-javascript/pull/425/files#diff-9b2324bba31437d1ca01432b814e10bcf00777d71d1ffc0a23d3b2481bda0132R10
Should have the same effect, but keep things structured.
jakeglobus
force-pushed
the
add-index-roles-crud
branch
from
f5e8c7d to
cb173c9
Compare
jakeglobus
force-pushed
the
add-index-roles-crud
branch
from
cb173c9 to
913abae
Compare
| export * as roles from './roles.js'; | ||
|
|
||
| /** |
There was a problem hiding this comment.
Ah of course, thanks Joe!
🤖 I have created a release *beep* *boop* --- ## [5.5.0](v5.4.1...v5.5.0) (2025-02-06) ### Features * **Search:** Adds support for Search Index Roles CRUD methods. ([#425](#425)) ([1b40d08](1b40d08)) ### Bug Fixes * **Transfer, Typescript:** Adds TransferErrorDocument type and improves DirectoryListingError types. ([#420](#420)) ([aadfbdf](aadfbdf)) * **Typescript, Search:** Improve the GFacet Search type ([#426](#426)) ([1b245a5](1b245a5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2 participants
No description provided.