prudebug: Add support for AM57x #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- AM57x1: Support PRU 1 core 0 and 1 - AM57x2: Support PRU 2 core 0 and 1 Changes: - modified: README.md Add the 2 new options AM57x1 and 2 modified: prudbg.c - Add AM57x1 and 2 modified: prudbg.h - Add #defines for AM57x1 and 2 - Make AM57x1 as default
giuliomoro
reviewed
Jul 15, 2021
prudbg.h
Outdated
| @@ -10,14 +10,15 @@ | |||
| #define PRUDBG_H | |||
|
|
|||
| // default processor to use if none is specified on the command line when prudebug is started | |||
| #define DEFAULT_PROCESSOR_INDEX AM335x | |||
| #define DEFAULT_PROCESSOR_INDEX AM57x1 | |||
There was a problem hiding this comment.
I don't like the change of default. I'd leave the old one. Later we could add an autodetect feature
|
it looks good, thanks. I would undo the line that sets the AM5 as default. So the "byte instead of word addressing" commit by Mark Yoder was not needed in the end? |
Nope. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
j <num>and the restss,halt,r, etc. are also all working fine.New Features:
Changes:
modified: README.md
Add the 2 new options AM57x1 and 2
modified: prudbg.c
Add AM57x1 and 2
modified: prudbg.h