Skip to content
This repository was archived by the owner on Jan 22, 2024. It is now read-only.

Conversation

@github-learning-lab
Copy link
Contributor

Now that your release is finalized, we have a confession to make... somewhere in our recent update, I made a mistake and introduced a bug. Instead of changing the text colors to green, we changed the whole background.

Sometimes GitHub Pages takes a few minutes to update. Your page might not immediately show the recent updates you've made.

image

"Hotfixes", or a quick fix to address a bug in software, are a normal part of development. Oftentimes you'll see application updates whose only description is "bug fixes".

When bugs come up after you release a version, you'll need to address them.

We've already created this branch, pull request, and suggested a fix. The suggested change will be merged into the master branch. Later we will cherry-pick the hotfix commits into the release branch.

Step 12: Approve a hotfix pull request

Submit a hotfix by applying the the suggested change and approving this PR.

⌨️ Activity: Apply the suggestion

  1. Click Commit suggestion
  2. Enter a commit message
  3. Click Commit changes
  4. Approve this pull request

I'll respond below with your next steps

Co-Authored-By: github-learning-lab[bot] <37936606+github-learning-lab[bot]@users.noreply.github.com>
@github-learning-lab github-learning-lab bot merged commit c20a759 into master Mar 3, 2020
@github-learning-lab
Copy link
Contributor Author

Your fix is now on master! This ensures that any new code isn't based on our bug.

Let's backport those changes to the branch with release v1.0.


Go to the next pull request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants