-
Notifications
You must be signed in to change notification settings - Fork 43
Move update-project and create-project-status-update to unified handler #13084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ect handler manager - Update JavaScript PROJECT_HANDLER_MAP to only include create_project and copy_project - Update Go hasProjectHandlerManagerTypes to exclude UpdateProjects and CreateProjectStatusUpdates - Move permissions for update-project and create-project-status-update to unified handler section - Remove obsolete tests for these types in project handler manager - These types are now handled by the unified handler instead of the separate project step Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…handler - Move these handlers from projectHandlerRegistry to handlerRegistry in compiler_safe_outputs_config.go - Add project field to both handler configs so project URL is passed to handlers - Update tests to expect these handlers in main config, not project config - Update TestUpdateProjectWithProjectURLConfig to check handler config instead of GH_AW_PROJECT_URL - Update TestCreateProjectStatusUpdateWithProjectURLConfig similarly - All project-related tests now pass Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
Agent Container Tool Check
Result: 9/12 tools available ❌ Missing tools:
|
|
[WIP] Remove all project-related tests from smoke-copilot workflow
|
Smoke Test ResultsPRs Tested: #13088, #13087
Status: PASS ✅ @pelikhan
|
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
Smoke Test: Claude ✅PRs Reviewed: #13088, #13087 Overall Status: PASS
|
update-projectandcreate-project-status-updatewere processed twice: once by the dedicated project handler manager step and again by the unified handler.Changes
Handler Architecture
update_projectandcreate_project_status_updatefromprojectHandlerRegistrytohandlerRegistrycreate_projectandcopy_projectprojectfield to both handler configs to pass project URLJavaScript (
safe_output_project_handler_manager.cjs)Go (
compiler_safe_outputs_job.go)hasProjectHandlerManagerTypesto only checkCreateProjectsandCopyProjectsUpdateProjectsandCreateProjectStatusUpdatesto unified handler sectionGo (
compiler_safe_outputs_config.go)Tests
GH_AW_SAFE_OUTPUTS_HANDLER_CONFIGinstead ofGH_AW_SAFE_OUTPUTS_PROJECT_HANDLER_CONFIGOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
Changeset