Skip to content

Fix: Use workflow ID instead of workflow name for comment search #13072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
Feb 1, 2026
Merged

Fix: Use workflow ID instead of workflow name for comment search #13072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9bad86f
Initial plan
Copilot Feb 1, 2026
113e855
Fix workflow ID usage in add_comment.cjs to use GH_AW_WORKFLOW_ID ins…
Copilot Feb 1, 2026
875519d
Complete fix for workflow ID usage in add_comment.cjs
Copilot Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion actions/setup/js/add_comment.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ async function main(config = {}) {
const createdComments = [];

// Get workflow ID for hiding older comments
const workflowId = process.env.GITHUB_WORKFLOW || "";
const workflowId = process.env.GH_AW_WORKFLOW_ID || "";

/**
* Message handler function
Expand Down
8 changes: 4 additions & 4 deletions actions/setup/js/add_comment.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ describe("add_comment", () => {
process.env.GH_AW_SAFE_OUTPUT_MESSAGES = JSON.stringify({
appendOnlyComments: true,
});
process.env.GITHUB_WORKFLOW = "test-workflow";
process.env.GH_AW_WORKFLOW_ID = "test-workflow";

let hideCommentsWasCalled = false;
let listCommentsCalls = 0;
Expand Down Expand Up @@ -458,15 +458,15 @@ describe("add_comment", () => {

// Clean up
delete process.env.GH_AW_SAFE_OUTPUT_MESSAGES;
delete process.env.GITHUB_WORKFLOW;
delete process.env.GH_AW_WORKFLOW_ID;
});

it("should hide older comments when append-only-comments is not enabled", async () => {
const addCommentScript = fs.readFileSync(path.join(__dirname, "add_comment.cjs"), "utf8");

// Set up environment variable WITHOUT append-only-comments
delete process.env.GH_AW_SAFE_OUTPUT_MESSAGES;
process.env.GITHUB_WORKFLOW = "test-workflow";
process.env.GH_AW_WORKFLOW_ID = "test-workflow";

let hideCommentsWasCalled = false;
let listCommentsCalls = 0;
Expand Down Expand Up @@ -525,7 +525,7 @@ describe("add_comment", () => {
expect(capturedComment.body).toContain("New comment - should hide old ones");

// Clean up
delete process.env.GITHUB_WORKFLOW;
delete process.env.GH_AW_WORKFLOW_ID;
});
});

Expand Down
11 changes: 2 additions & 9 deletions scratchpad/serena-tools-data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,14 +132,7 @@
}
],
"serena_tools_detail": {
"used_tools": [
"mcp__serena__check_onboarding_performed",
"mcp__serena__find_symbol",
"mcp__serena__get_current_config",
"mcp__serena__initial_instructions",
"mcp__serena__list_memories",
"mcp__serena__search_for_pattern"
],
"used_tools": ["mcp__serena__check_onboarding_performed", "mcp__serena__find_symbol", "mcp__serena__get_current_config", "mcp__serena__initial_instructions", "mcp__serena__list_memories", "mcp__serena__search_for_pattern"],
"unused_registered_tools": [
"serena___activate_project",
"serena___delete_memory",
Expand Down Expand Up @@ -448,4 +441,4 @@
}
]
}
}
}
Loading