Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Feb 1, 2026

The hide-older-comments feature was searching by workflow name ("Smoke Claude") instead of workflow ID ("smoke-claude"), causing it to miss previous comments with matching <!-- gh-aw-workflow-id: {id} --> markers.

Changes

  • add_comment.cjs: Changed process.env.GITHUB_WORKFLOW to process.env.GH_AW_WORKFLOW_ID (line 305)
  • add_comment.test.cjs: Updated test fixtures to use GH_AW_WORKFLOW_ID environment variable

The workflow compiler already sets GH_AW_WORKFLOW_ID correctly via GetWorkflowIDFromPath() in the safe-outputs job. This change aligns the comment handler with that existing behavior.

// Before
const workflowId = process.env.GITHUB_WORKFLOW || "";  // "Smoke Claude"

// After  
const workflowId = process.env.GH_AW_WORKFLOW_ID || "";  // "smoke-claude"
Original prompt

The workflow id used to search for older issues should be the id, not the workflow title.

Notice the log comment below where the JavaScript is looking for the workflow name, not the id. Review JavaScript or generated code for error.

Searching for previous comments with workflow ID: Smoke Claude

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits February 1, 2026 11:15
…tead of GITHUB_WORKFLOW

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix issue with workflow id used for searching older issues Fix: Use workflow ID instead of workflow name for comment search Feb 1, 2026
Copilot AI requested a review from pelikhan February 1, 2026 11:22
@pelikhan pelikhan marked this pull request as ready for review February 1, 2026 11:24
@pelikhan pelikhan added the smoke label Feb 1, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2026

📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing...

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2026

🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2026

🎬 THE ENDSmoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2026

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2026

Agent Container Tool Check

Tool Status Version
bash 5.2.21
sh available
git 2.52.0
jq 1.7
yq 4.50.1
curl available
gh 2.86.0
node 24.13.0
python3 available
go 1.24.12
java not found
dotnet not found

Result: 10/12 tools available
Status: ❌ FAIL - Java and .NET runtimes not installed

Note: Core shell tools, version control, JSON/YAML processing, HTTP tools, GitHub CLI, and Node/Python/Go runtimes are all available.

AI generated by Agent Container Smoke Test

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2026

GitHub MCP merged PRs: Add MCP tool usage statistics to audit command; Ignore safe-outputs.jobs messages in handler managers ✅
Safeinputs GH PR list: [WIP] Update project to skip processing safe outputs; [WIP] Add summarized tool call information to logs ✅
Serena activate_project ✅
Playwright github.com title contains "GitHub" ✅
Tavily search results returned ✅
File write /tmp/gh-aw/agent/smoke-test-codex-21562063600.txt ✅
Bash cat verify ✅
Discussion query + oracle comment ✅
Build make build ✅
Overall status: PASS

AI generated by Smoke Codex

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2026

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2026

Smoke Test: Claude ✅

Last 2 Merged PRs:

Test Results:

  • ✅ GitHub MCP
  • ✅ Safe Inputs GH CLI
  • ✅ Serena MCP
  • ✅ Make Build
  • ✅ Playwright
  • ✅ Tavily
  • ✅ File Writing
  • ✅ Bash Tool
  • ✅ Discussion Interaction

Overall Status: PASS ✅

AI generated by Smoke Claude

@pelikhan pelikhan merged commit 945adcf into main Feb 1, 2026
163 of 164 checks passed
@pelikhan pelikhan deleted the copilot/fix-workflow-id-search branch February 1, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants