Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 27, 2026

Updates the test suite to reflect the architectural change that allows campaign orchestrators to have GitHub tool access for discovery operations.

Changes:

  • Updated TestBuildOrchestrator_DispatchOnlyPolicy to expect GitHub tools to be configured in orchestrators
  • Changed test assertion from expecting NO GitHub tools to expecting GitHub tools with repos, issues, and pull_requests toolsets
  • Updated test comment to clarify: "Orchestrators should have GitHub tool access for discovery operations"

Before:

// Orchestrators should not have GitHub tool access to the agent.
if data.Tools != nil {
    if _, ok := data.Tools["github"]; ok {
        t.Fatalf("expected orchestrator to omit github tools")
    }
}

After:

// Orchestrators should have GitHub tool access for discovery operations
if data.Tools == nil {
    t.Fatalf("expected Tools to be configured")
}
if _, ok := data.Tools["github"]; !ok {
    t.Fatalf("expected orchestrator to have github tools configured")
}

This change aligns with the new architecture where orchestrators can perform GitHub API operations directly rather than being limited to only dispatching workflows.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Copilot AI changed the title [WIP] Simplify and update campaign orchestrator's discovery process fix: remove GitHub tools from campaign orchestrators Jan 27, 2026
Copilot AI requested a review from mnkiefer January 27, 2026 20:51
@mnkiefer
Copy link
Contributor

mnkiefer commented Jan 27, 2026

@copilot We no longer have the architectural constraint that orchestrators only coordinate via dispatch-workflow

Copy link
Contributor Author

Copilot AI commented Jan 27, 2026

@copilot We no longer have the architectural constraint that orchestrators only coordinate via dispatch-workflow

Updated in commit 26c198a. Restored the GitHub tools configuration for orchestrators and updated the test to reflect the new architecture where orchestrators can have GitHub tool access for discovery operations.

Copilot AI changed the title fix: remove GitHub tools from campaign orchestrators fix: update test expectations for GitHub tools in campaign orchestrators Jan 27, 2026
@mnkiefer mnkiefer marked this pull request as ready for review January 27, 2026 21:04
@mnkiefer mnkiefer merged commit 23e17aa into simple-discovery Jan 27, 2026
@mnkiefer mnkiefer deleted the copilot/sub-pr-12106 branch January 27, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants