-
Notifications
You must be signed in to change notification settings - Fork 43
Add diagnostic logging and increase timeout for safe-outputs MCP server startup failures #11930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot increase timeout to 60 seconds |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot revert all *.lock.yml files |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot merge main, recompile, format, lint |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
@copilot create logger and use them instead of directly using process.stderr |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
Tests: GitHub MCP ✅; gh CLI ✅; Serena ✅; Playwright ✅; Tavily ✅; File ✅; Bash ✅; Discussion ✅
|
Smoke Test ResultsPRs Tested:
Status:
Overall: ✅ PASS @pelikhan
|
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
Smoke Test Results - Claude EngineStatus: ✅ PASS (9/9 tests) Merged PRs Reviewed:
Tests: Run: §21373219714
|
|
@copilot merge main and recompile |
…ge-agent-failure-again # Conflicts: # .github/workflows/go-pattern-detector.lock.yml # .github/workflows/super-linter.lock.yml # .github/workflows/unbloat-docs.lock.yml
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Fix PR Triage Agent Workflow Failure - Safe Outputs MCP Server Startup Timeout
Problem Summary
The PR Triage Agent workflow fails because the Safe Outputs MCP HTTP server doesn't start within the timeout period. The server process starts but produces no log output and never responds on port 3001.
Failing workflow: https://github.com/githubnext/gh-aw/actions/runs/21368688445
Investigation Complete ✅
Key Findings:
/opt/gh-aw/safeoutputs/Changes Made
1. Debug Logging with Proper Logger ✅
Implemented comprehensive debug logging using the
createLogger()utility at critical initialization points:safe-outputs-mcp-server.cjs): UsescreateLogger("safe-outputs-entry")to track Node.js execution and module loadingsafe_outputs_mcp_server_http.cjs): Uses module logger andcreateLogger("safe-outputs-startup")to log each require() statement and function entrymcp_http_transport.cjs): UsescreateLogger("MCPServer")andcreateLogger("MCPHTTPTransport")to track connect() and start() async operationsmcp_server_core.cjs): Uses module logger to confirm module initializationAll log messages include:
[2026-01-26T20:29:28.069Z][safe-outputs-entry],[safeoutputs],[MCPServer], etc.2. Timeout Increased ✅
start_safe_outputs_server.shattempt X/60instead ofattempt X/103. Workflow Updates ✅
make recompilemake fmtmake lintLocal Test Results ✅
Successfully tested with exact workflow file setup and new logger:
Next Steps
To Complete Fix:
Expected Debug Output:
The comprehensive logging with proper logger combined with increased timeout will reveal exactly where execution stops or hangs, enabling a precise fix.
Files Modified
actions/setup/js/safe-outputs-mcp-server.cjs- Entry point logging with createLoggeractions/setup/js/safe_outputs_mcp_server_http.cjs- Module loading and function call logging with createLoggeractions/setup/js/mcp_http_transport.cjs- Connect and start logging with createLoggeractions/setup/js/mcp_server_core.cjs- Module load logging with createLoggeractions/setup/sh/start_safe_outputs_server.sh- Increased timeout from 10s to 60sOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
Changeset
Changeset