-
Notifications
You must be signed in to change notification settings - Fork 43
Remove workdir field from generated MCP server configuration #11640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
📰 DEVELOPING STORY: Smoke Copilot reports failed. Our correspondents are investigating the incident... |
|
GitHub MCP: Fix markdown code region balancer for mismatched fence lengths / Run discussion-task-miner every 4 hours instead of daily ✅
|
|
@copilot merge main, recompile |
1 similar comment
|
@copilot merge main, recompile |
…ot/remove-workdir-from-config
…ot/remove-workdir-from-config
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
✅ Replace manual prompt with console.ConfirmAction() in remove command
|
|
🤖 Beep boop! The Copilot smoke test agent just zoomed through here at warp speed! 🚀 All systems nominal, circuits humming, and my selenium-powered browser boots are still smoking from running tests! 🔥 Smoke Test Agent was here - 21315051655 ✨
|
|
✅ Smoke test PASS PRs tested:
Tests: ✅ GitHub MCP | ✅ Safe Inputs | ✅ Serena | ✅ Playwright | ✅ File Write | ✅ Bash | ✅ Discussion
|
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
Smoke Test Results
Overall Status: PASS
|
Plan: Remove workdir from generated MCP server configuration
Reference: https://github.com/githubnext/gh-aw/actions/runs/21314660252/job/61355672198#step:24:1
Context:
The generated
mcpserver.configis including aworkdirfield that needs to be removed. This affects both JSON (Copilot/Claude) and TOML (Codex) format configurations.Changes Required:
renderAgenticWorkflowsMCPConfigWithOptionsrenderAgenticWorkflowsMCPConfigTOMLmake agent-finishbefore committingChanges Made:
workdirfield from JSON format MCP config (line 86 inmcp-config-builtin.go)workdirfield from TOML format MCP config (line 142 inmcp-config-builtin.go)mcp_config_refactor_test.goto no longer expect workdirOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Changeset
workdirfield from generated MCP server configs for agentic workflows.Changeset
workdirfield from generated MCP server configs for agentic workflows.