Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 24, 2026

Plan: Remove workdir from generated MCP server configuration

Reference: https://github.com/githubnext/gh-aw/actions/runs/21314660252/job/61355672198#step:24:1

Context:
The generated mcpserver.config is including a workdir field that needs to be removed. This affects both JSON (Copilot/Claude) and TOML (Codex) format configurations.

Changes Required:

  • Understand the codebase and identify where workdir is added
  • Remove workdir from JSON format in renderAgenticWorkflowsMCPConfigWithOptions
  • Remove workdir from TOML format in renderAgenticWorkflowsMCPConfigTOML
  • Update related tests that verify workdir presence
  • Run tests to validate changes
  • Run make agent-finish before committing
  • Merge main branch
  • Recompile workflows

Changes Made:

  1. Removed workdir field from JSON format MCP config (line 86 in mcp-config-builtin.go)
  2. Removed workdir field from TOML format MCP config (line 142 in mcp-config-builtin.go)
  3. Updated test expectations in mcp_config_refactor_test.go to no longer expect workdir
  4. Verified all related tests pass
  5. Manually tested with sample workflows to confirm workdir is removed
  6. Merged main branch
  7. Recompiled all workflow lock files to reflect the workdir removal
Original prompt

Reference: https://github.com/githubnext/gh-aw/actions/runs/21314660252/job/61355672198#step:24:1

Remove

  "workdir": "/home/runner/work/gh-aw/gh-aw",

from generated mcpserver.config


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.


Changeset

  • Type: patch
  • Description: Removed the stray workdir field from generated MCP server configs for agentic workflows.

Ahoy! This treasure was crafted by 🏴‍☠️ Changeset Generator


Changeset

  • Type: patch
  • Description: Removed the stray workdir field from generated MCP server configs for agentic workflows.

Ahoy! This treasure was crafted by 🏴‍☠️ Changeset Generator

Copilot AI and others added 5 commits January 24, 2026 11:31
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Base automatically changed from copilot/update-gh-aw-mcpg-version to main January 24, 2026 11:57
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove workdir from generated mcpserver.config Remove workdir field from generated MCP server configuration Jan 24, 2026
Copilot AI requested a review from pelikhan January 24, 2026 12:09
@pelikhan pelikhan added the smoke label Jan 24, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2026

🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2026

🎬 THE ENDSmoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2026

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

@github-actions
Copy link
Contributor

📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing...

@github-actions
Copy link
Contributor

📰 DEVELOPING STORY: Smoke Copilot reports failed. Our correspondents are investigating the incident...

@github-actions
Copy link
Contributor

GitHub MCP: Fix markdown code region balancer for mismatched fence lengths / Run discussion-task-miner every 4 hours instead of daily ✅
Safeinputs gh: [WIP] Update upgrade doc page to include agentic upgrade instructions / [WIP] Update GitHub Actions workflows documentation with safe output types ✅
Serena activate ✅; Playwright title ✅
Tavily search ✅; File write ✅
Bash cat ✅; Discussion comment ✅
Overall: PASS

AI generated by Smoke Codex

@pelikhan
Copy link
Contributor

@copilot merge main, recompile

1 similar comment
@pelikhan
Copy link
Contributor

@copilot merge main, recompile

Copilot AI and others added 3 commits January 24, 2026 12:21
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 24, 2026

@copilot merge main, recompile

Merged main and recompiled workflows. The workdir field has been removed from all 10 affected workflow lock files. (eacec01)

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2026

🎬 THE ENDSmoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2026

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2026

🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰

@github-actions
Copy link
Contributor

📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing...

Copy link
Contributor Author

Copilot AI commented Jan 24, 2026

@copilot merge main, recompile

Already up-to-date. The branch was merged with main and workflows were recompiled in the previous commit (eacec01). No new changes on main since then.

@github-actions
Copy link
Contributor

✅ Replace manual prompt with console.ConfirmAction() in remove command
✅ Fix markdown code region balancer for mismatched fence lengths
✅ Add agentic upgrade instructions to documentation
✅ Add missing dispatch-workflow to safe output documentation
✅ Serena MCP activate_project
✅ Playwright title contains GitHub
✅ Tavily search returned results
✅ File write + cat verification
✅ Discussion oracle comment posted
Overall status: PASS

AI generated by Smoke Codex

@github-actions
Copy link
Contributor

🤖 Beep boop! The Copilot smoke test agent just zoomed through here at warp speed! 🚀

All systems nominal, circuits humming, and my selenium-powered browser boots are still smoking from running tests! 🔥

Smoke Test Agent was here - 21315051655

AI generated by Smoke Copilot

@github-actions
Copy link
Contributor

✅ Smoke test PASS

PRs tested:

Tests: ✅ GitHub MCP | ✅ Safe Inputs | ✅ Serena | ✅ Playwright | ✅ File Write | ✅ Bash | ✅ Discussion

@copilot-swe-agent @pelikhan

AI generated by Smoke Copilot

@github-actions
Copy link
Contributor

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

@github-actions
Copy link
Contributor

Smoke Test Results

PRs Retrieved: #11643, #11642

Test Result
GitHub MCP
Safe Inputs GH CLI
Serena MCP
Make Build
Playwright
Tavily Search
File Writing
Bash Tool
Discussion Interaction

Overall Status: PASS

AI generated by Smoke Claude

@pelikhan pelikhan marked this pull request as ready for review January 24, 2026 12:29
@pelikhan pelikhan merged commit f1485b8 into main Jan 24, 2026
84 checks passed
@pelikhan pelikhan deleted the copilot/remove-workdir-from-config branch January 24, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants