Skip to content

Fix failing tests by updating field type expectations from 'number' to 'NUMBER' #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benbalter merged 2 commits into from
Aug 15, 2025
Merged

Fix failing tests by updating field type expectations from 'number' to 'NUMBER' #184

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7200b66
Initial plan
Copilot Aug 15, 2025
03bb111
Fix failing tests by updating field type from 'number' to 'NUMBER'
Copilot Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions __test__/main.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,23 +28,23 @@ test("valueGraphqlType returns String for text", () => {
});

test("convertValueToFieldType converts string to number for number field", () => {
const result = updateProject.convertValueToFieldType("42", "number");
const result = updateProject.convertValueToFieldType("42", "NUMBER");
expect(result).toBe(42);
});

test("convertValueToFieldType converts string to float for number field", () => {
const result = updateProject.convertValueToFieldType("3.14", "number");
const result = updateProject.convertValueToFieldType("3.14", "NUMBER");
expect(result).toBe(3.14);
});

test("convertValueToFieldType converts zero string to number for number field", () => {
const result = updateProject.convertValueToFieldType("0", "number");
const result = updateProject.convertValueToFieldType("0", "NUMBER");
expect(result).toBe(0);
});

test("convertValueToFieldType throws error for invalid number", () => {
expect(() => {
updateProject.convertValueToFieldType("not-a-number", "number");
updateProject.convertValueToFieldType("not-a-number", "NUMBER");
}).toThrow("Invalid number value: not-a-number");
});

Expand Down
Loading