Fix failing tests by updating field type expectations from 'number' to 'NUMBER' #184
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
convertValueToFieldTypefunction tests were failing because they were passing the incorrect field type parameter. The function expects"NUMBER"(uppercase) but the tests were passing"number"(lowercase).This mismatch caused four test failures:
convertValueToFieldType converts string to number for number fieldconvertValueToFieldType converts string to float for number fieldconvertValueToFieldType converts zero string to number for number fieldconvertValueToFieldType throws error for invalid numberThe fix updates all test expectations to use
"NUMBER"instead of"number", which aligns with the function's implementation that checks forfieldType === "NUMBER".All tests now pass (30/30) and the code builds and lints successfully.
Fixes #183.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.