feat: Tracking pull request time in draft state #415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zack Koppert <zkoppert@github.com>
Signed-off-by: Zack Koppert <zkoppert@github.com>
Signed-off-by: Zack Koppert <zkoppert@github.com>
…te failing tests that were using positional args Signed-off-by: Zack Koppert <zkoppert@github.com>
Signed-off-by: Zack Koppert <zkoppert@github.com>
Signed-off-by: Zack Koppert <zkoppert@github.com>
Signed-off-by: Zack Koppert <zkoppert@github.com>
…raft time stats for multiple issues Signed-off-by: Zack Koppert <zkoppert@github.com>
Signed-off-by: Zack Koppert <zkoppert@github.com>
Signed-off-by: Zack Koppert <zkoppert@github.com>
Signed-off-by: Zack Koppert <zkoppert@github.com>
Closed
jmeridth
approved these changes
Oct 24, 2024
Co-authored-by: JM (Jason Meridth) <jmeridth@gmail.com>
Co-authored-by: JM (Jason Meridth) <jmeridth@gmail.com>
Co-authored-by: JM (Jason Meridth) <jmeridth@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
fixes #353
Proposed Changes
This pull request introduces a new feature to track the time pull requests (PRs) spend in draft mode and includes various updates to the codebase to support this functionality. The most important changes include updates to the
README.mdfor documentation, modifications to theIssueWithMetricsclass, and updates to theconfig.pyandissue_metrics.pyfiles to handle the new draft PR tracking feature. PR's that bypass draft mode report results asNone.Readiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducing@jeffrey-luszczReviewer
fix,documentation,enhancement,infrastructure,maintenance, orbreakingExample Markdown Output
Issue Metrics
This report was generated with the Issue Metrics Action
Search query used to find these items:
repo:github/issue-metrics is:pr author:zkoppert created:2024-01-01..2024-10-14Example json output
{ "average_time_to_first_response": "4:12:27", "average_time_to_close": "9:20:13", "average_time_to_answer": "None", "average_time_in_draft": "3:17:41", "average_time_in_labels": {}, "median_time_to_first_response": "0:08:15", "median_time_to_close": "0:58:37", "median_time_to_answer": "None", "median_time_in_draft": "0:04:50", "median_time_in_labels": {}, "90_percentile_time_to_first_response": "6:46:59", "90_percentile_time_to_close": "1 day, 1:01:31", "90_percentile_time_to_answer": "None", "90_percentile_time_in_draft": "9:47:12", "90_percentile_time_in_labels": {}, "num_items_opened": 0, "num_items_closed": 24, "num_mentor_count": 0, "total_item_count": 24, "issues": [ { "title": "feat: add bypass to rate limiter", "html_url": "https://github.com/github/issue-metrics/pull/396", "author": "zkoppert", "time_to_first_response": "2 days, 5:21:02", "time_to_close": "2 days, 12:42:29", "time_to_answer": "None", "time_in_draft": "0:04:16", "label_metrics": {} }, { "title": "chore: Remove unneeded pip install", "html_url": "https://github.com/github/issue-metrics/pull/393", "author": "zkoppert", "time_to_first_response": "0:00:35", "time_to_close": "0:02:24", "time_to_answer": "None", "time_in_draft": "None", "label_metrics": {} }, { "title": "docs: Add OSSF Best Practices Badge", "html_url": "https://github.com/github/issue-metrics/pull/392", "author": "zkoppert", "time_to_first_response": "1:24:08", "time_to_close": "1:24:24", "time_to_answer": "None", "time_in_draft": "None", "label_metrics": {} }, { "title": "chore: use setup python to improve OSSF scorecard", "html_url": "https://github.com/github/issue-metrics/pull/391", "author": "zkoppert", "time_to_first_response": "0:53:00", "time_to_close": "0:53:14", "time_to_answer": "None", "time_in_draft": "0:43:01", "label_metrics": {} }, { "title": "Dont merge, testing", "html_url": "https://github.com/github/issue-metrics/pull/386", "author": "zkoppert", "time_to_first_response": "None", "time_to_close": "None", "time_to_answer": "None", "time_in_draft": "None", "label_metrics": {} }, { "title": "fix: Remove more general part of duplicate actions permissions", "html_url": "https://github.com/github/issue-metrics/pull/382", "author": "zkoppert", "time_to_first_response": "0:01:08", "time_to_close": "0:58:37", "time_to_answer": "None", "time_in_draft": "0:00:29", "label_metrics": {} }, { "title": "fix: Remove ignore_users authored items from markdown results", "html_url": "https://github.com/github/issue-metrics/pull/379", "author": "zkoppert", "time_to_first_response": "0:01:52", "time_to_close": "0:02:49", "time_to_answer": "None", "time_in_draft": "0:05:25", "label_metrics": {} }, { "title": "fix: Catch review comments with no valid user", "html_url": "https://github.com/github/issue-metrics/pull/326", "author": "zkoppert", "time_to_first_response": "0:00:53", "time_to_close": "0:33:51", "time_to_answer": "None", "time_in_draft": "None", "label_metrics": {} }, { "title": "fix: catch error that occurs when ghost usre creates an event.", "html_url": "https://github.com/github/issue-metrics/pull/325", "author": "zkoppert", "time_to_first_response": "0:01:35", "time_to_close": "7:03:38", "time_to_answer": "None", "time_in_draft": "None", "label_metrics": {} }, { "title": "chore: pin shas in Dockerfile", "html_url": "https://github.com/github/issue-metrics/pull/315", "author": "zkoppert", "time_to_first_response": "0:08:15", "time_to_close": "0:14:39", "time_to_answer": "None", "time_in_draft": "None", "label_metrics": {} }, { "title": "feat: Add option to hide Number of items closed metric", "html_url": "https://github.com/github/issue-metrics/pull/313", "author": "zkoppert", "time_to_first_response": "0:02:29", "time_to_close": "1 day, 0:48:49", "time_to_answer": "None", "time_in_draft": "0:01:31", "label_metrics": {} }, { "title": "fix: issue counts incorrect when HIDE_TIME_TO_CLOSE is True", "html_url": "https://github.com/github/issue-metrics/pull/311", "author": "zkoppert", "time_to_first_response": "15:12:32", "time_to_close": "1 day, 19:34:15", "time_to_answer": "None", "time_in_draft": "None", "label_metrics": {} }, { "title": "chore: add Jacob to pr reviews automatically", "html_url": "https://github.com/github/issue-metrics/pull/304", "author": "zkoppert", "time_to_first_response": "0:02:36", "time_to_close": "0:03:24", "time_to_answer": "None", "time_in_draft": "None", "label_metrics": {} }, { "title": "ci: Add Jeff to review new data releases", "html_url": "https://github.com/github/issue-metrics/pull/298", "author": "zkoppert", "time_to_first_response": "0:02:17", "time_to_close": "0:09:52", "time_to_answer": "None", "time_in_draft": "None", "label_metrics": {} }, { "title": "ci: release when a new feature hits main", "html_url": "https://github.com/github/issue-metrics/pull/296", "author": "zkoppert", "time_to_first_response": "0:02:03", "time_to_close": "0:05:46", "time_to_answer": "None", "time_in_draft": "None", "label_metrics": {} }, { "title": "chore: Switch to weekly dep updates to reduce noise", "html_url": "https://github.com/github/issue-metrics/pull/278", "author": "zkoppert", "time_to_first_response": "1:35:16", "time_to_close": "1:40:57", "time_to_answer": "None", "time_in_draft": "None", "label_metrics": {} }, { "title": "feat: Split markdown files when larger than max issue body size", "html_url": "https://github.com/github/issue-metrics/pull/265", "author": "zkoppert", "time_to_first_response": "0:34:16", "time_to_close": "1 day, 1:04:42", "time_to_answer": "None", "time_in_draft": "None", "label_metrics": {} }, { "title": "fix: handle multiple repos in search query", "html_url": "https://github.com/github/issue-metrics/pull/261", "author": "zkoppert", "time_to_first_response": "4:40:36", "time_to_close": "17:13:18", "time_to_answer": "None", "time_in_draft": "None", "label_metrics": {} }, { "title": "fix: Performance fix to only measure statistics which are not hidden", "html_url": "https://github.com/github/issue-metrics/pull/239", "author": "zkoppert", "time_to_first_response": "1:07:24", "time_to_close": "23:08:08", "time_to_answer": "None", "time_in_draft": "None", "label_metrics": {} }, { "title": "switch to v3", "html_url": "https://github.com/github/issue-metrics/pull/223", "author": "zkoppert", "time_to_first_response": "0:44:33", "time_to_close": "4:08:46", "time_to_answer": "None", "time_in_draft": "18:51:23", "label_metrics": {} }, { "title": "Update CODEOWNERS", "html_url": "https://github.com/github/issue-metrics/pull/220", "author": "zkoppert", "time_to_first_response": "None", "time_to_close": "0:06:37", "time_to_answer": "None", "time_in_draft": "None", "label_metrics": {} }, { "title": "Use keep label to exempt issues from stale action", "html_url": "https://github.com/github/issue-metrics/pull/216", "author": "zkoppert", "time_to_first_response": "None", "time_to_close": "0:05:00", "time_to_answer": "None", "time_in_draft": "None", "label_metrics": {} }, { "title": "Create stale.yaml", "html_url": "https://github.com/github/issue-metrics/pull/214", "author": "zkoppert", "time_to_first_response": "None", "time_to_close": "2:29:51", "time_to_answer": "None", "time_in_draft": "None", "label_metrics": {} }, { "title": "Update issue creation action version", "html_url": "https://github.com/github/issue-metrics/pull/201", "author": "zkoppert", "time_to_first_response": "None", "time_to_close": "0:09:39", "time_to_answer": "None", "time_in_draft": "None", "label_metrics": {} } ], "search_query": "repo:github/issue-metrics is:pr author:zkoppert created:2024-01-01..2024-10-14" }