Skip to content

Conversation

@zkoppert
Copy link
Member

@zkoppert zkoppert commented Jun 10, 2024

Pull Request

Fixes #310

Proposed Changes

This pull request improves the get_per_issue_metrics function in issue_metrics.py by ...

  • Expanding the test coverage in test_issue_metrics.py to cover counting logic when env vars are set
  • Changing the issue counting logic so it is not gated by the HIDE_TIME_TO_CLOSE env var

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance, or breaking

Signed-off-by: Zack Koppert <zkoppert@github.com>
@github-actions github-actions bot added the fix label Jun 10, 2024
zkoppert and others added 2 commits June 11, 2024 08:59
Co-authored-by: jmeridth <jmeridth@gmail.com>
Signed-off-by: Zack Koppert <zkoppert@github.com>
@zkoppert zkoppert merged commit 418d42b into main Jun 12, 2024
@zkoppert zkoppert deleted the fix_issue_count branch June 12, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Items closed/opened counts are incorrect when HIDE_TIME_TO_CLOSE is True

4 participants