Skip to content

[WIP] Update agentic workflows server name to agenticworkflows#14198

Closed
Copilot wants to merge 1 commit intomainfrom
copilot/update-agentic-workflows-server-name
Closed

[WIP] Update agentic workflows server name to agenticworkflows#14198
Copilot wants to merge 1 commit intomainfrom
copilot/update-agentic-workflows-server-name

Conversation

Copy link
Contributor

Copilot AI commented Feb 6, 2026

✅ Verification Complete: Agentic Workflows Server Name Consistency

Goal: Review and ensure the agentic workflows MCP server name is consistently "agenticworkflows" (no dash, no underscore) across all JSON/config/go/js code generators.

Summary

All MCP server configurations correctly use "agenticworkflows"
All tests pass
Code review completed with no issues
No changes needed

Verification Steps Completed

  • Explored codebase to understand current naming conventions
  • Reviewed Go constants (pkg/constants/constants.go)
  • Reviewed MCP config rendering code (pkg/workflow/mcp_*.go)
  • Reviewed JSON schema (pkg/parser/schemas/main_workflow_schema.json)
  • Reviewed JavaScript files (actions/setup/js/*.cjs)
  • Compiled test workflow and verified output
  • Verified generated lock files
  • Ran all agentic workflow tests
  • Requested and passed code review

Detailed Findings

1. MCP Server ID (Primary Focus)

  • Go constant (pkg/constants/constants.go:545):
    const AgenticWorkflowsMCPServerID = "agenticworkflows"
  • JSON config rendering (pkg/workflow/mcp_config_builtin.go:173):
    yaml.WriteString("\"" + constants.AgenticWorkflowsMCPServerID + "\": {\n")
  • TOML config rendering (pkg/workflow/mcp_config_builtin.go:289, mcp_renderer.go:415):
    yaml.WriteString("[mcp_servers." + constants.AgenticWorkflowsMCPServerID + "]\n")
  • Generated lock files: All use "agenticworkflows" as server name
  • Test verification (pkg/workflow/agentic_workflow_test.go:125-126):
    assert.Contains(t, result, constants.AgenticWorkflowsMCPServerID,
        "%s engine should generate MCP config with agenticworkflows server name", e.name)

2. Naming Pattern Consistency

The codebase follows a consistent pattern across all built-in MCP servers:

Tool (Frontmatter YAML) MCP Server ID (Internal) Constant
"agentic-workflows" "agenticworkflows" AgenticWorkflowsMCPServerID
"safe-outputs" "safeoutputs" SafeOutputsMCPServerID
"safe-inputs" "safeinputs" SafeInputsMCPServerID

Pattern: User-facing YAML keys use kebab-case, internal server IDs use lowercase (no separators)

3. Different Naming Contexts

The following uses of "agentic-workflows" with dashes are intentional and serve different purposes:

Context Name Purpose File
YAML tool key "agentic-workflows" User-facing configuration Frontmatter tools section
VSCode display "github-agentic-workflows" VSCode UI display name .vscode/mcp.json, pkg/cli/mcp_config_file.go
User agent default "github-agentic-workflow" Fallback for GitHub API pkg/workflow/mcp_renderer.go:477
Workflow ID default "github-agentic-workflow" Fallback identifier pkg/workflow/workflow_name.go:40

None of these are MCP server IDs and do not need to change.

Test Results

=== RUN   TestAgenticWorkflowsMCPConfigGeneration
=== RUN   TestAgenticWorkflowsMCPConfigGeneration/Claude
=== RUN   TestAgenticWorkflowsMCPConfigGeneration/Copilot
=== RUN   TestAgenticWorkflowsMCPConfigGeneration/Custom
=== RUN   TestAgenticWorkflowsMCPConfigGeneration/Codex
--- PASS: TestAgenticWorkflowsMCPConfigGeneration (0.00s)

All tests pass, confirming the server name "agenticworkflows" is correctly used everywhere.

Conclusion

No changes needed - The agentic workflows MCP server name is already consistently "agenticworkflows" (no dash, no underscore) in all MCP server configurations across:

  • Go code generators
  • JSON configuration rendering
  • TOML configuration rendering
  • Generated GitHub Actions workflow files
  • Test assertions

The use of "agentic-workflows" (with dash) in YAML frontmatter and VSCode configuration is intentional and follows established conventions in the codebase.

Original prompt

Make sure the agentic workflows server name is "agenticworkflows" (no dash, no understcore). Review all JSON/config/go/js code generator


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants